home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 1120990806 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

  • simonw 2
  • codecov[bot] 1

author_association 2

  • OWNER 2
  • NONE 1

issue 1

  • Ensure template_path always uses "/" to match jinja · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1028419517 https://github.com/simonw/datasette/pull/1617#issuecomment-1028419517 https://api.github.com/repos/simonw/datasette/issues/1617 IC_kwDOBm6k_c49TG-9 codecov[bot] 22429695 2022-02-02T22:30:26Z 2022-02-03T01:36:07Z NONE

Codecov Report

Merging #1617 (af293c9) into main (2aa686c) will increase coverage by 0.06%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #1617 +/-

========================================== + Coverage 92.09% 92.16% +0.06%
========================================== Files 34 34
Lines 4518 4531 +13
========================================== + Hits 4161 4176 +15
+ Misses 357 355 -2
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/app.py | 95.37% <100.00%> (ø) | | | datasette/views/table.py | 96.19% <0.00%> (ø) | | | datasette/utils/__init__.py | 94.79% <0.00%> (+<0.01%) | :arrow_up: | | datasette/views/base.py | 95.49% <0.00%> (+0.07%) | :arrow_up: | | datasette/views/special.py | 95.09% <0.00%> (+2.38%) | :arrow_up: |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2aa686c...af293c9. Read the comment docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ensure template_path always uses "/" to match jinja 1120990806  
1028519382 https://github.com/simonw/datasette/pull/1617#issuecomment-1028519382 https://api.github.com/repos/simonw/datasette/issues/1617 IC_kwDOBm6k_c49TfXW simonw 9599 2022-02-03T01:31:25Z 2022-02-03T01:31:25Z OWNER

I was hoping to get the test suite running on Windows before merging this PR but that looks like it will be a BIG job, see: - #1627

So I'm going to merge this one as-is for the moment.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ensure template_path always uses "/" to match jinja 1120990806  
1028517073 https://github.com/simonw/datasette/pull/1617#issuecomment-1028517073 https://api.github.com/repos/simonw/datasette/issues/1617 IC_kwDOBm6k_c49TezR simonw 9599 2022-02-03T01:26:32Z 2022-02-03T01:26:32Z OWNER

Aha I understand the problem now! https://github.com/pallets/jinja/issues/1378#issuecomment-812410922

Jinja template names/paths are not always filesystem paths. So regardless of the OS Jinja always uses forward slashes.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ensure template_path always uses "/" to match jinja 1120990806  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 22.825ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows