issue_comments

Table actions

7 rows where issue = 1138948786 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add SpatiaLite helpers to CLI · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1040998433 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040998433 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-DGAh eyeseast 25778 2022-02-16T01:29:39Z 2022-02-16T01:29:39Z CONTRIBUTOR

Happy to do it and have it in the library. Going to use it a bunch. This whole SpatiaLite toolchain become a huge part of my work in the past year.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040959312 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040959312 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-C8dQ simonw 9599 2022-02-16T00:58:32Z 2022-02-16T00:58:32Z OWNER

This is honestly one of the most complete PRs I've ever seen for a feature of this size. Thanks so much for this!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040519196 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040519196 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-BRAc codecov[bot] 22429695 2022-02-15T16:52:21Z 2022-02-15T18:12:03Z NONE

Codecov Report

Merging #407 (a974da5) into main (e7f0401) will increase coverage by 0.71%. The diff coverage is 85.00%.

```diff @@ Coverage Diff @@

main #407 +/-

========================================== + Coverage 95.91% 96.62% +0.71%
========================================== Files 6 6
Lines 2421 2460 +39
========================================== + Hits 2322 2377 +55
+ Misses 99 83 -16
```

| Impacted Files | Coverage Δ | | |---|---|---| | sqlite_utils/cli.py | 95.76% <85.00%> (+0.06%) | :arrow_up: | | sqlite_utils/utils.py | 94.59% <0.00%> (ø) | | | sqlite_utils/db.py | 97.72% <0.00%> (+1.43%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7f0401...a974da5. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040598665 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040598665 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-BkaJ simonw 9599 2022-02-15T17:58:11Z 2022-02-15T17:58:11Z OWNER

Wow, just found out I can edit files in this PR branch by hitting . on my keyboard while looking at the PR, then making changes in the VS Code for web on github.dev!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040596969 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040596969 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-Bj_p simonw 9599 2022-02-15T17:56:22Z 2022-02-15T17:56:35Z OWNER

We should add SpatiaLite to the action that calculates code coverage - that way we can calculate coverage across the new GIS tests as well: https://github.com/simonw/sqlite-utils/blob/main/.github/workflows/test-coverage.yml

Should just be a case of adding this to that workflow - we can do this in the same PR.

- name: Install SpatiaLite run: sudo apt-get install libsqlite3-mod-spatialite

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040595572 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040595572 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-Bjp0 simonw 9599 2022-02-15T17:54:58Z 2022-02-15T17:54:58Z OWNER

This PR looks fantastic.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  
1040580250 https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040580250 https://api.github.com/repos/simonw/sqlite-utils/issues/407 IC_kwDOCGYnMM4-Bf6a eyeseast 25778 2022-02-15T17:40:00Z 2022-02-15T17:40:00Z CONTRIBUTOR

@simonw I think this is ready for a look.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add SpatiaLite helpers to CLI 1138948786  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);