issue_comments

Table actions

7 rows where issue = 1173017980 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Remove hashed URL mode · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1072898923 https://github.com/simonw/datasette/pull/1664#issuecomment-1072898923 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_8yNr simonw 9599 2022-03-19T00:11:33Z 2022-03-19T00:11:33Z OWNER

I'm going to land this and handle those in separate commits.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1072898797 https://github.com/simonw/datasette/pull/1664#issuecomment-1072898797 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_8yLt simonw 9599 2022-03-19T00:11:09Z 2022-03-19T00:11:09Z OWNER

Still need to remove it from the documentation and do something about that hash_urls setting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1072890524 https://github.com/simonw/datasette/pull/1664#issuecomment-1072890524 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_8wKc simonw 9599 2022-03-18T23:44:33Z 2022-03-19T00:06:51Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1072890205 https://github.com/simonw/datasette/pull/1664#issuecomment-1072890205 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_8wFd simonw 9599 2022-03-18T23:43:15Z 2022-03-18T23:43:15Z OWNER

Now almost everything is working except for foreign key expansion:

Using the debugger I tracked it down to this code:

https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L708-L715

Turns out default_labels there is None - and it's a parameter to that data() method: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L325-L334

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071813296 https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4pKw simonw 9599 2022-03-17T23:26:22Z 2022-03-17T23:26:22Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071809988 https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4oXE simonw 9599 2022-03-17T23:24:57Z 2022-03-17T23:24:57Z OWNER

My hunch is that this is broken because of this:

https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/app.py#L1098-L1107

Note how the table uses table_and_format but the row uses just table - I think there's code that's getting confused by this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071803114 https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4mrq simonw 9599 2022-03-17T23:22:00Z 2022-03-17T23:22:00Z OWNER

Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);