issue_comments

Table actions

4 rows where issue = 1237586379 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • ?_trace=1 fails with datasette-geojson for some reason · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1128064864 https://github.com/simonw/datasette/issues/1742#issuecomment-1128064864 https://api.github.com/repos/simonw/datasette/issues/1742 IC_kwDOBm6k_c5DPOdg eyeseast 25778 2022-05-16T19:42:13Z 2022-05-16T19:42:13Z CONTRIBUTOR

Just to add a wrinkle here, this loads fine: https://alltheplaces-datasette.fly.dev/alltheplaces/places.geojson?_trace=1

But also, this doesn't add any trace data: https://alltheplaces-datasette.fly.dev/alltheplaces/places.json?_trace=1

What am I missing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_trace=1 fails with datasette-geojson for some reason 1237586379  
1128052948 https://github.com/simonw/datasette/issues/1742#issuecomment-1128052948 https://api.github.com/repos/simonw/datasette/issues/1742 IC_kwDOBm6k_c5DPLjU simonw 9599 2022-05-16T19:28:31Z 2022-05-16T19:28:31Z OWNER

The trace mechanism is a bit gnarly - it's actually done by some ASGI middleware I wrote, so I'm pretty sure the bug is in there somewhere: https://github.com/simonw/datasette/blob/280ff372ab30df244f6c54f6f3002da57334b3d7/datasette/tracer.py#L73

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_trace=1 fails with datasette-geojson for some reason 1237586379  
1128049716 https://github.com/simonw/datasette/issues/1742#issuecomment-1128049716 https://api.github.com/repos/simonw/datasette/issues/1742 IC_kwDOBm6k_c5DPKw0 eyeseast 25778 2022-05-16T19:24:44Z 2022-05-16T19:24:44Z CONTRIBUTOR

Where is _trace getting injected? And is it something a plugin should be able to handle? (If it is, I guess I should handle it in this case.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_trace=1 fails with datasette-geojson for some reason 1237586379  
1128033018 https://github.com/simonw/datasette/issues/1742#issuecomment-1128033018 https://api.github.com/repos/simonw/datasette/issues/1742 IC_kwDOBm6k_c5DPGr6 simonw 9599 2022-05-16T19:06:38Z 2022-05-16T19:06:38Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_trace=1 fails with datasette-geojson for some reason 1237586379  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);