issue_comments

Table actions

5 rows where issue = 1306984363 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • minor a11y: <select> has no visual indicator when tabbed to · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1356694671 https://github.com/simonw/datasette/issues/1771#issuecomment-1356694671 https://api.github.com/repos/simonw/datasette/issues/1771 IC_kwDOBm6k_c5Q3YSP simonw 9599 2022-12-18T06:34:20Z 2022-12-18T06:34:20Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 minor a11y: <select> has no visual indicator when tabbed to 1306984363  
1356680769 https://github.com/simonw/datasette/issues/1771#issuecomment-1356680769 https://api.github.com/repos/simonw/datasette/issues/1771 IC_kwDOBm6k_c5Q3U5B simonw 9599 2022-12-18T05:56:05Z 2022-12-18T05:56:05Z OWNER

This does the trick:

css div.select-wrapper:focus-within { border: 1px solid black; } 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 minor a11y: <select> has no visual indicator when tabbed to 1306984363  
1356657451 https://github.com/simonw/datasette/issues/1771#issuecomment-1356657451 https://api.github.com/repos/simonw/datasette/issues/1771 IC_kwDOBm6k_c5Q3PMr mustafa0x 1473102 2022-12-18T04:04:32Z 2022-12-18T04:04:32Z NONE

the problem is: .select-wrapper select:focus { outline: none; }

I sometimes add this js: window.addEventListener('keydown', function check_tab(e) { if (e.key === 'Tab') { document.documentElement.classList.add('user-is-tabbing') window.removeEventListener('keydown', check_tab) } })

and then in the css, using a html.user-is-tabbing selector undo any outlines I removed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 minor a11y: <select> has no visual indicator when tabbed to 1306984363  
1356655630 https://github.com/simonw/datasette/issues/1771#issuecomment-1356655630 https://api.github.com/repos/simonw/datasette/issues/1771 IC_kwDOBm6k_c5Q3OwO simonw 9599 2022-12-18T03:43:12Z 2022-12-18T03:43:12Z OWNER

The border is actually on the div that wraps the select box:

I tried adding a border: 1px dotted black to select:focus but it's not quite right - it jumps around a bit like this:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 minor a11y: <select> has no visual indicator when tabbed to 1306984363  
1356655217 https://github.com/simonw/datasette/issues/1771#issuecomment-1356655217 https://api.github.com/repos/simonw/datasette/issues/1771 IC_kwDOBm6k_c5Q3Opx simonw 9599 2022-12-18T03:38:16Z 2022-12-18T03:38:16Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 minor a11y: <select> has no visual indicator when tabbed to 1306984363  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);