issue_comments

Table actions

5 rows where issue = 1420174670 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • NoneType' object has no attribute 'actor' · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1292654852 https://github.com/simonw/datasette/issues/1849#issuecomment-1292654852 https://api.github.com/repos/simonw/datasette/issues/1849 IC_kwDOBm6k_c5NDFkE simonw 9599 2022-10-26T21:08:44Z 2022-10-26T21:08:44Z OWNER

Generally though we should expect that people might try to use render_template(...) without passing a request, so Datasette core should be able to handle this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 NoneType' object has no attribute 'actor' 1420174670  
1292654522 https://github.com/simonw/datasette/issues/1849#issuecomment-1292654522 https://api.github.com/repos/simonw/datasette/issues/1849 IC_kwDOBm6k_c5NDFe6 simonw 9599 2022-10-26T21:08:20Z 2022-10-26T21:08:20Z OWNER

From the stack trace in Sentry:

So this happened because a custom plugin tried to render forbidden.html without passing in the request.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 NoneType' object has no attribute 'actor' 1420174670  
1292653219 https://github.com/simonw/datasette/issues/1849#issuecomment-1292653219 https://api.github.com/repos/simonw/datasette/issues/1849 IC_kwDOBm6k_c5NDFKj simonw 9599 2022-10-26T21:06:56Z 2022-10-26T21:06:56Z OWNER

This was a hit to an authenticated page where the incoming user WAS logged in but did not have permission to view that specific page.

Code in question: https://github.com/simonw/datasette/blob/c7dd76c26257ded5bcdfd0570e12412531b8b88f/datasette/app.py#L634-L640

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 NoneType' object has no attribute 'actor' 1420174670  
1288384907 https://github.com/simonw/datasette/issues/1849#issuecomment-1288384907 https://api.github.com/repos/simonw/datasette/issues/1849 IC_kwDOBm6k_c5MyzGL simonw 9599 2022-10-24T04:04:02Z 2022-10-24T04:04:02Z OWNER

Refs: - #1831 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 NoneType' object has no attribute 'actor' 1420174670  
1288384098 https://github.com/simonw/datasette/issues/1849#issuecomment-1288384098 https://api.github.com/repos/simonw/datasette/issues/1849 IC_kwDOBm6k_c5Myy5i simonw 9599 2022-10-24T04:03:09Z 2022-10-24T04:03:09Z OWNER

Looks like the new breadcrumbs code can't handle the case where request is None.

Need a test that demonstrates this too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 NoneType' object has no attribute 'actor' 1420174670  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);