issue_comments

Table actions

7 rows where issue = 1422915587 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 7 ✖

issue 1

  • Upgrade Datasette Docker to Python 3.11 · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1291036623 https://github.com/simonw/datasette/issues/1853#issuecomment-1291036623 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M86fP simonw 9599 2022-10-25T19:28:56Z 2022-10-25T19:28:56Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1291032289 https://github.com/simonw/datasette/issues/1853#issuecomment-1291032289 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M85bh simonw 9599 2022-10-25T19:24:27Z 2022-10-25T19:24:27Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1291023926 https://github.com/simonw/datasette/issues/1853#issuecomment-1291023926 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M83Y2 simonw 9599 2022-10-25T19:15:49Z 2022-10-25T19:15:49Z OWNER

This broke the deploy of https://latest.datasette.io/ - because it tries to install pysqlite3-binary which doesn't have a 3.11 release yet:

https://github.com/simonw/datasette/blob/2e9751672d4fe329b3c359d5b7b1992283185820/.github/workflows/deploy-latest.yml#L77

I started using that for the latest.datasette.io demo in https://github.com/simonw/datasette/commit/a970276b9999687b96c5e11ea1c817d814f5d267 because I wanted a version of SQLite that supported generated columns.

Those were added in SQLite 3.31.0 - and the SQLite version in the new base image is 3.34.1 - so I don't actually need pysqlite3-binary any more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1291012637 https://github.com/simonw/datasette/issues/1853#issuecomment-1291012637 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M80od simonw 9599 2022-10-25T19:04:03Z 2022-10-25T19:04:09Z OWNER

And tested datasette package like this:

datasette package fixtures.db -t datasette-package-python-upgrade-3-11 Then: docker run -p 8081:8001 datasette-package-python-upgrade-3-11 And tested it like this: curl http://localhost:8081/-/versions.json | jq Output: { "python": { "version": "3.11.0", "full": "3.11.0 (main, Oct 25 2022, 05:00:36) [GCC 10.2.1 20210110]" },

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1291009987 https://github.com/simonw/datasette/issues/1853#issuecomment-1291009987 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M8z_D simonw 9599 2022-10-25T19:01:23Z 2022-10-25T19:01:23Z OWNER

Also tested by running this locally:

datasette publish cloudrun fixtures.db --service issue-1853

https://issue-1853-j7hipcg4aq-uc.a.run.app/-/versions now shows Python 3.11.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1291006149 https://github.com/simonw/datasette/issues/1853#issuecomment-1291006149 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M8zDF simonw 9599 2022-10-25T18:57:33Z 2022-10-25T18:57:33Z OWNER

Ran the upgrade on the Datasette Cloud image first, works fine there.

https://simon.datasette.cloud/-/versions shows me:

{ "python": { "version": "3.11.0", "full": "3.11.0 (main, Oct 25 2022, 05:00:36) [GCC 10.2.1 20210110]" },

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  
1290995178 https://github.com/simonw/datasette/issues/1853#issuecomment-1290995178 https://api.github.com/repos/simonw/datasette/issues/1853 IC_kwDOBm6k_c5M8wXq simonw 9599 2022-10-25T18:46:33Z 2022-10-25T18:46:33Z OWNER

I ran a very crude benchmark on my laptop using Locust (against the official macOS packages from www.python.org for Python 3.10 and Python 3.11) and saw a substantial speed increase:

533.89 requests/second on 3.11 413.56 requests/second on 3.10

That was from running Locust against this locustfile.py: ```python from locust import HttpUser, task

class CounterOne(HttpUser): @task def hello(self): self.client.get("/-/static/app.css") ``` Using:

locust --headless --users 4 --spawn-rate 4 -H http://127.0.0.1:8001

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade Datasette Docker to Python 3.11 1422915587  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);