issue_comments

Table actions

3 rows where issue = 1423336122 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • allow_signed_tokens setting for disabling API signed token mechanism · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1291410747 https://github.com/simonw/datasette/issues/1856#issuecomment-1291410747 https://api.github.com/repos/simonw/datasette/issues/1856 IC_kwDOBm6k_c5M-V07 simonw 9599 2022-10-26T02:27:05Z 2022-10-26T02:27:05Z OWNER

Because of that I think this is a better name:

--setting allow_signed_tokens off

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 allow_signed_tokens setting for disabling API signed token mechanism 1423336122  
1291410331 https://github.com/simonw/datasette/issues/1856#issuecomment-1291410331 https://api.github.com/repos/simonw/datasette/issues/1856 IC_kwDOBm6k_c5M-Vub simonw 9599 2022-10-26T02:26:19Z 2022-10-26T02:26:19Z OWNER

It's a bit confusing that a setting called allow_create_tokens also causes incoming dstok_ tokens to be ignored.

Is it confusing enough that I should pick a different name for the setting though?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 allow_signed_tokens setting for disabling API signed token mechanism 1423336122  
1291409312 https://github.com/simonw/datasette/issues/1856#issuecomment-1291409312 https://api.github.com/repos/simonw/datasette/issues/1856 IC_kwDOBm6k_c5M-Veg simonw 9599 2022-10-26T02:24:49Z 2022-10-26T02:24:49Z OWNER

The effect of this setting will be:

  • /-/create-tokens interface is no longer available
  • Incoming dstok_ tokens are no longer respected by the following code:

https://github.com/simonw/datasette/blob/b29e487bc3fde6418bf45bda7cfed2e081ff03fb/datasette/default_permissions.py#L52-L72

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 allow_signed_tokens setting for disabling API signed token mechanism 1423336122  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);