issue_comments

Table actions

8 rows where issue = 1453813400 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Some plugins show "home" breadcrumbs twice in the top left · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1319525520 https://github.com/simonw/datasette/issues/1901#issuecomment-1319525520 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5OplyQ simonw 9599 2022-11-18T04:21:14Z 2022-11-18T07:22:37Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319627012 https://github.com/simonw/datasette/issues/1901#issuecomment-1319627012 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op-kE simonw 9599 2022-11-18T07:07:03Z 2022-11-18T07:07:03Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319493475 https://github.com/simonw/datasette/issues/1901#issuecomment-1319493475 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opd9j simonw 9599 2022-11-18T03:19:25Z 2022-11-18T07:03:03Z OWNER

Other plugins this looks like it will affect:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319623911 https://github.com/simonw/datasette/issues/1901#issuecomment-1319623911 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op9zn simonw 9599 2022-11-18T07:02:56Z 2022-11-18T07:02:56Z OWNER

That's all of them!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319588163 https://github.com/simonw/datasette/issues/1901#issuecomment-1319588163 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Op1FD simonw 9599 2022-11-18T06:05:11Z 2022-11-18T06:05:11Z OWNER

For datasette-copyable I want to show breadcrumbs that take database/instance permissions into account, so I'm removing {% block nav %} entirely and replacing it with this:

html+jinja {% block crumbs %} {{ crumbs.nav(request=request, database=database, table=table) }} {% endblock %}

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319528359 https://github.com/simonw/datasette/issues/1901#issuecomment-1319528359 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opmen simonw 9599 2022-11-18T04:27:00Z 2022-11-18T04:27:00Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319483555 https://github.com/simonw/datasette/issues/1901#issuecomment-1319483555 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5Opbij simonw 9599 2022-11-18T03:02:35Z 2022-11-18T03:02:35Z OWNER

Looks like this issue could affect a bunch of other plugins too: https://cs.github.com/?scopeName=All+repos&scope=&q=%3Cp+class%3D%22crumbs%22%3E+user%3Asimonw

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  
1319482791 https://github.com/simonw/datasette/issues/1901#issuecomment-1319482791 https://api.github.com/repos/simonw/datasette/issues/1901 IC_kwDOBm6k_c5OpbWn simonw 9599 2022-11-18T03:01:36Z 2022-11-18T03:01:36Z OWNER

Good catch. Looks like that bug was introduced by this change: https://github.com/simonw/datasette/commit/1a5e5f2aa951e5bd731067a49819efba68fbe8ef

From:

The search all plugin includes this code which interacts poorly with that refactor:

https://github.com/simonw/datasette-search-all/blob/847b55c368a285e4567627029624d7872ee75cac/datasette_search_all/templates/search_all.html#L31-L36

html+jinja {% block nav %} <p class="crumbs"> <a href="{{ urls.instance() }}">home</a> </p> {{ super() }} {% endblock %}

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Some plugins show "home" breadcrumbs twice in the top left 1453813400  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);