issue_comments

Table actions

3 rows where issue = 1651082214 and user = 15178711 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • asg017 · 3 ✖

issue 1

  • feat: Javascript Plugin API (Custom panels, column menu items with JS actions) · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1616095810 https://github.com/simonw/datasette/pull/2052#issuecomment-1616095810 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5gU6pC asg017 15178711 2023-07-01T20:31:31Z 2023-07-01T20:31:31Z CONTRIBUTOR

Just curious, is there a query that can be used to compile this programmatically, or did you identify these through memory?

I just did a github search for user:simonw "def extra_js_urls(" ! Though I'm sure other plugins made by people other than Simon also exist out there https://github.com/search?q=user%3Asimonw+%22def+extra_js_urls%28%22&type=code

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  
1613778296 https://github.com/simonw/datasette/pull/2052#issuecomment-1613778296 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5gME14 asg017 15178711 2023-06-29T20:36:09Z 2023-06-29T20:36:09Z CONTRIBUTOR

Ok @hydrosquall a couple things before this PR should be good to go:

  • Can we move datasette/static/table-example-plugins.js into demos/plugins/static?
  • For datasetteManager.VERSION, can we fill that in or just comment it out for now? Not sure how difficult it'll be to inject it server-side. I imagine we could also have a small build process with esbuild/rollup that just injects a version string into manager.js directly, so we don't have to worry about server-rendering (but that can be a future PR)

In terms of how to integrate this into Datasette, a few options I can see working:

  • Push this as-is and figure it out before the next release
  • Hide this feature behind a settings flag (--setting unstable-js-plugins on) and use that setting to hide/show <script src="{{ urls.static('datasette-manager.js') }}" defer></script> in base.html

I'll let @simonw decide which one to work with. I kindof like the idea of having an "unstable" opt-in process to enable JS plugins, to give us time to try it out with a wide variety of plugins until we feel its ready.

I'm also curious to see how "plugins for a plugin' would work, like #1542. For example, if the leaflet plugin showed default markers, but also included its own hook for other plugins to add more markers/styling. I'm imagine that the individual plugin would re-create their own plugin system compared to this, since handling "plugins of plugins" at the top with Datasette seems really convoluted.

Also for posterity, here's a list of Simon's Datasette plugins that use "extra_js_urls()", which probably means they can be ported/re-written to use this new plugin system:

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  
1606352600 https://github.com/simonw/datasette/pull/2052#issuecomment-1606352600 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5fvv7Y asg017 15178711 2023-06-26T00:17:04Z 2023-06-26T00:17:04Z CONTRIBUTOR

:wave: would love to see this get merged soon! I want to make a javascript plugin on top of the code-mirror editor to make a few things nicer (function auto-complete, table/column descriptions, etc.), and this would help out a bunch

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);