issue_comments

Table actions

5 rows where issue = 1818838294 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Plugin hook for adding new output formats · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1668113177 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1668113177 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5jbWMZ eyeseast 25778 2023-08-07T15:41:49Z 2023-08-07T15:41:49Z CONTRIBUTOR

I wonder if this should be two hooks: input and output. The current --csv (and --tsv) options apply to both. Haven't looked at how it's implemented. Or maybe it's one hook that returns a format for reading and for writing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  
1648339661 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1648339661 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5iP6rN eyeseast 25778 2023-07-24T17:44:30Z 2023-07-24T17:44:30Z CONTRIBUTOR

A related feature would be support for plugins to add new ways of ingesting data - currently sqlite-utils insert works against JSON, newline-JSON, CSV and TSV.

This is my goal, to have one plugin that handles input and output symmetrically. I'd like to be able to do something like this:

```sh sqlite-utils insert data.db table file.geojson --format geojson

... explore and manipulate in Datasette

sqlite-utils query data.db ... --format geojson > output.geojson ```

This would work especially well with datasette-query-files, since I already have the queries I need saved in standalone SQL files.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  
1648325682 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1648325682 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5iP3Qy simonw 9599 2023-07-24T17:33:10Z 2023-07-24T17:33:10Z OWNER

A related feature would be support for plugins to add new ways of ingesting data - currently sqlite-utils insert works against JSON, newline-JSON, CSV and TSV.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  
1648324312 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1648324312 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5iP27Y simonw 9599 2023-07-24T17:32:21Z 2023-07-24T17:32:21Z OWNER

I'm currently leaning very slightly towards --format geojson - and explaining in the docs that --format is for formats added by plugins.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  
1648323482 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1648323482 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5iP2ua simonw 9599 2023-07-24T17:31:56Z 2023-07-24T17:31:56Z OWNER

The main blocker here is coming up with a design. The challenge is cleanly integrating it with the existing format options:

https://github.com/simonw/sqlite-utils/blob/8bee14588687b66c54c7a3dfae5de2f9cc7cac3f/docs/cli-reference.rst#L114-L132

I'd like to avoid breaking backwards compatibility.

The most obvious solution is to add a --format x option. This is slightly confusing as --fmt already exists.

Or... --fmt could be enhanced to handle plugins too - and the existing set of formats (from the tabulate integration) could be refactored to use the new hook.

If I ever do release sqlite-utils 4 I'm tempted to move that tabulate stuff into a plugin.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);