issue_comments

Table actions

9 rows where issue = 1859415334 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Bump sphinx, furo, blacken-docs dependencies · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1696591957 https://github.com/simonw/datasette/pull/2148#issuecomment-1696591957 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5lH_BV dependabot[bot] 49699333 2023-08-29T00:15:29Z 2023-08-29T00:15:29Z CONTRIBUTOR

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1696591943 https://github.com/simonw/datasette/pull/2148#issuecomment-1696591943 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5lH_BH simonw 9599 2023-08-29T00:15:27Z 2023-08-29T00:15:27Z OWNER

Now solving this here: - #2160 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689133247 https://github.com/simonw/datasette/pull/2148#issuecomment-1689133247 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5kriC_ codecov[bot] 22429695 2023-08-23T01:36:42Z 2023-08-23T03:09:43Z NONE

Codecov Report

Patch coverage has no change and project coverage change: +0.01% :tada:

Comparison is base (17ec309) 92.71% compared to head (a651d3c) 92.73%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2148 +/- ## ========================================== + Coverage 92.71% 92.73% +0.01% ========================================== Files 40 40 Lines 5919 5919 ========================================== + Hits 5488 5489 +1 + Misses 431 430 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/simonw/datasette/pull/2148/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689198413 https://github.com/simonw/datasette/pull/2148#issuecomment-1689198413 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krx9N dependabot[bot] 49699333 2023-08-23T02:57:55Z 2023-08-23T02:57:55Z CONTRIBUTOR

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689198368 https://github.com/simonw/datasette/pull/2148#issuecomment-1689198368 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krx8g simonw 9599 2023-08-23T02:57:53Z 2023-08-23T02:57:53Z OWNER

@dependabot rebase

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689177556 https://github.com/simonw/datasette/pull/2148#issuecomment-1689177556 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krs3U simonw 9599 2023-08-23T02:44:29Z 2023-08-23T02:44:29Z OWNER

Simplest possible solution is to only run the pip install .[docs] bit under Python 3.9+, ditto for the docs tests. I think I'll try that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689175062 https://github.com/simonw/datasette/pull/2148#issuecomment-1689175062 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krsQW simonw 9599 2023-08-23T02:40:46Z 2023-08-23T02:40:46Z OWNER

Here's why the tests are failing:

https://github.com/simonw/datasette/blob/2ce7872e3ba8d07248c194ef554bbdc1df510f32/.github/workflows/test.yml#L30-L46

It looks like those tests don't actually need Sphinx installed - they install pip install -e '.[test,docs]' to get the other docs dependencies:

https://github.com/simonw/datasette/blob/2ce7872e3ba8d07248c194ef554bbdc1df510f32/setup.py#L70-L80

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689173748 https://github.com/simonw/datasette/pull/2148#issuecomment-1689173748 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krr70 simonw 9599 2023-08-23T02:38:31Z 2023-08-23T02:38:31Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1689127479 https://github.com/simonw/datasette/pull/2148#issuecomment-1689127479 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5krgo3 simonw 9599 2023-08-23T01:26:53Z 2023-08-23T01:26:53Z OWNER

@dependabot recreate

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);