issue_comments

Table actions

6 rows where issue = 1874327336 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1699910555 https://github.com/simonw/datasette/pull/2165#issuecomment-1699910555 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lUpOb simonw 9599 2023-08-30T22:05:14Z 2023-08-30T22:05:14Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  
1699812599 https://github.com/simonw/datasette/pull/2165#issuecomment-1699812599 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lURT3 codecov[bot] 22429695 2023-08-30T20:43:19Z 2023-08-30T22:05:05Z NONE

Codecov Report

Patch coverage: 26.66% and project coverage change: -0.17% :warning:

Comparison is base (30b28c8) 92.84% compared to head (5eddf34) 92.68%.

:exclamation: Current head 5eddf34 differs from pull request most recent head 6321c9c. Consider uploading reports for the commit 6321c9c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2165 +/- ## ========================================== - Coverage 92.84% 92.68% -0.17% ========================================== Files 40 40 Lines 5998 6012 +14 ========================================== + Hits 5569 5572 +3 - Misses 429 440 +11 ``` | [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/plugins.py](https://app.codecov.io/gh/simonw/datasette/pull/2165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3BsdWdpbnMucHk=) | `64.58% <26.66%> (-17.77%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  
1699884314 https://github.com/simonw/datasette/pull/2165#issuecomment-1699884314 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lUi0a simonw 9599 2023-08-30T21:38:29Z 2023-08-30T21:39:51Z OWNER

Here's the reason for that name disparity:

https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L54-L65

Note how the distinfo.project_name name is used when available. That seems to work for regularly installed plugins but not for plugins loaded via DATASETTE_LOAD_PLUGINS.

And that's looking things up in plugin_to_distinfo which is populated here:

https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L37

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  
1699811810 https://github.com/simonw/datasette/pull/2165#issuecomment-1699811810 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lURHi simonw 9599 2023-08-30T20:42:41Z 2023-08-30T20:42:41Z OWNER

The load_setuptools_entrypoints() function in Pluggy does this:

python for ep in dist.entry_points: if ( ep.group != group or (name is not None and ep.name != name) # already registered or self.get_plugin(ep.name) or self.is_blocked(ep.name) ): continue plugin = ep.load() self.register(plugin, name=ep.name)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  
1699809688 https://github.com/simonw/datasette/pull/2165#issuecomment-1699809688 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lUQmY simonw 9599 2023-08-30T20:41:06Z 2023-08-30T20:41:06Z OWNER

Slight weirdness: I noticed that the output from the datasette plugins command looks like this for plugins loaded with the new environment variable: json { "name": "datasette_pretty_json", "static": false, "templates": false, "version": null, "hooks": [ "render_cell" ] }, That should ideally be datasette-pretty-json, not datasette_pretty_json.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  
1699802028 https://github.com/simonw/datasette/pull/2165#issuecomment-1699802028 https://api.github.com/repos/simonw/datasette/issues/2165 IC_kwDOBm6k_c5lUOus simonw 9599 2023-08-30T20:35:02Z 2023-08-30T20:35:02Z OWNER

Testing this is going to be a bit of a pain.

I think I'll add a whole separate test block to CI which installs a couple of plugins and then exercises this feature using datasette plugins.

I'll use datasette-init and datasette-json-html just because they are small and simple.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins 1874327336  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);