issue_comments

Table actions

3 rows where issue = 1978023780 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • request.post_vars() method obliterates form keys with multiple values · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1794054390 https://github.com/simonw/datasette/issues/2205#issuecomment-1794054390 https://api.github.com/repos/simonw/datasette/issues/2205 IC_kwDOBm6k_c5q7xj2 simonw 9599 2023-11-06T04:09:43Z 2023-11-06T04:10:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.post_vars() method obliterates form keys with multiple values 1978023780  
1794052079 https://github.com/simonw/datasette/issues/2205#issuecomment-1794052079 https://api.github.com/repos/simonw/datasette/issues/2205 IC_kwDOBm6k_c5q7w_v simonw 9599 2023-11-06T04:06:05Z 2023-11-06T04:08:50Z OWNER

It should return a MultiParams:

https://github.com/simonw/datasette/blob/452a587e236ef642cbc6ae345b58767ea8420cb5/datasette/utils/init.py#L900-L917

Change needs to be made before 1.0.

python return MultiParams(urllib.parse.parse_qs(body.decode("utf-8"))) Need to remember why I was using keep_blank_values=True there and check that using MultiParams doesn't conflict with that reason.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.post_vars() method obliterates form keys with multiple values 1978023780  
1793880738 https://github.com/simonw/datasette/issues/2205#issuecomment-1793880738 https://api.github.com/repos/simonw/datasette/issues/2205 IC_kwDOBm6k_c5q7HKi simonw 9599 2023-11-05T23:26:14Z 2023-11-05T23:26:14Z OWNER

I found this problem while trying to use WTForms with this pattern:

```python choices = [(col, col) for col in await db.table_columns(table)]

class ConfigForm(Form): template = TextAreaField("Template") api_token = PasswordField("OpenAI API token") columns = MultiCheckboxField('Columns', choices=choices) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.post_vars() method obliterates form keys with multiple values 1978023780  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);