issue_comments

Table actions

7 rows where issue = 273127694 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Ship a Docker image of the whole thing · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
400903871 https://github.com/simonw/datasette/issues/57#issuecomment-400903871 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDQwMDkwMzg3MQ== simonw 9599 2018-06-28T04:01:38Z 2018-06-28T04:01:38Z OWNER

Shipped to Docker Hub: https://hub.docker.com/r/datasetteproject/datasette/

I did this manually the first time. I'll set Travis up to do this automatically in #329

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
344185817 https://github.com/simonw/datasette/issues/57#issuecomment-344185817 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0NDE4NTgxNw== simonw 9599 2017-11-14T08:46:24Z 2017-11-14T08:46:24Z OWNER

Thanks for the explanation! Please do start a pull request. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
344151223 https://github.com/simonw/datasette/issues/57#issuecomment-344151223 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0NDE1MTIyMw== macropin 247192 2017-11-14T05:32:28Z 2017-11-14T05:33:03Z CONTRIBUTOR

The pattern is called "multi-stage builds". And the result is a svelte 226MB image (201MB for 3.6-slim) vs 700MB+ for the full image. It's possible to get it even smaller, but that takes a lot more work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
344149165 https://github.com/simonw/datasette/issues/57#issuecomment-344149165 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0NDE0OTE2NQ== simonw 9599 2017-11-14T05:16:34Z 2017-11-14T05:17:14Z OWNER

I’m intrigued by this pattern:

https://github.com/macropin/datasette/blob/147195c2fdfa2b984d8f9fc1c6cab6634970a056/Dockerfile#L8

What’s the benefit of doing that? Does it result in a smaller image size?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
344147583 https://github.com/simonw/datasette/issues/57#issuecomment-344147583 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0NDE0NzU4Mw== macropin 247192 2017-11-14T05:03:47Z 2017-11-14T05:03:47Z CONTRIBUTOR

Let me know if you'd like a PR. The image is usable as docker run --rm -t -i -p 9000:8001 -v $(pwd)/db:/db datasette datasette serve /db/chinook.db

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
344145265 https://github.com/simonw/datasette/issues/57#issuecomment-344145265 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0NDE0NTI2NQ== macropin 247192 2017-11-14T04:45:38Z 2017-11-14T04:45:38Z CONTRIBUTOR

I'm happy to contribute this. Just let me know if you want a Dockerfile for development or production purposes, or both.

If it's prod then we can just pip install the source from pypi, otherwise for dev we'll need a requirements.txt to speed up rebuilds.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  
343769692 https://github.com/simonw/datasette/issues/57#issuecomment-343769692 https://api.github.com/repos/simonw/datasette/issues/57 MDEyOklzc3VlQ29tbWVudDM0Mzc2OTY5Mg== simonw 9599 2017-11-12T21:32:36Z 2017-11-12T21:32:36Z OWNER

I have created a Docker Hub public repository for this: https://hub.docker.com/r/simonwillison/datasette/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ship a Docker image of the whole thing 273127694  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);