issue_comments

Table actions

6 rows where issue = 274284246 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • [WIP] Add publish to heroku support · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
346124764 https://github.com/simonw/datasette/pull/104#issuecomment-346124764 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NjEyNDc2NA== jacobian 21148 2017-11-21T18:52:14Z 2017-11-21T18:52:14Z CONTRIBUTOR

OK, now this should work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  
346124073 https://github.com/simonw/datasette/pull/104#issuecomment-346124073 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NjEyNDA3Mw== jacobian 21148 2017-11-21T18:49:55Z 2017-11-21T18:49:55Z CONTRIBUTOR

Actually hang on, don't merge - there are some bugs that #141 masked when I tested this out elsewhere.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  
346116745 https://github.com/simonw/datasette/pull/104#issuecomment-346116745 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NjExNjc0NQ== jacobian 21148 2017-11-21T18:23:25Z 2017-11-21T18:23:25Z CONTRIBUTOR

@simonw ready for a review and merge if you want.

There's still some nasty duplicated code in cli.py and utils.py, which is just going to get worse if/when we start adding any other deploy targets (and I want to do one for cloud.gov, at least). I think there's an opportunity for some refactoring here. I'm happy to do that now as part of this PR, or if you merge this first I'll do it in a different one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  
345452669 https://github.com/simonw/datasette/pull/104#issuecomment-345452669 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NTQ1MjY2OQ== jacobian 21148 2017-11-18T16:18:45Z 2017-11-18T16:18:45Z CONTRIBUTOR

I'd like to do a bit of cleanup, and some error checking in case heroku/heroku-builds isn't installed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  
345447161 https://github.com/simonw/datasette/pull/104#issuecomment-345447161 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NTQ0NzE2MQ== simonw 9599 2017-11-18T14:53:17Z 2017-11-18T14:53:17Z OWNER

any reason I shouldn't land this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  
344710204 https://github.com/simonw/datasette/pull/104#issuecomment-344710204 https://api.github.com/repos/simonw/datasette/issues/104 MDEyOklzc3VlQ29tbWVudDM0NDcxMDIwNA== jacobian 21148 2017-11-15T19:57:50Z 2017-11-15T19:57:50Z CONTRIBUTOR

A first basic stab at making this work, just to prove the approach. Right now this requires a Heroku CLI plugin, which seems pretty unreasonable. I think this can be replaced with direct API calls, which could clean up a lot of things. But I wanted to prove it worked first, and it does.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [WIP] Add publish to heroku support 274284246  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);