issue_comments

Table actions

5 rows where issue = 275814941 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • datasette publish can fail if /tmp is on a different device · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
620970547 https://github.com/simonw/datasette/issues/141#issuecomment-620970547 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDYyMDk3MDU0Nw== simonw 9599 2020-04-29T03:27:37Z 2020-04-29T03:27:54Z OWNER

This bug raised its head again in #744

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  
350301248 https://github.com/simonw/datasette/issues/141#issuecomment-350301248 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDM1MDMwMTI0OA== simonw 9599 2017-12-08T16:07:04Z 2017-12-08T16:07:04Z OWNER

This fix should work, please have a go with latest master and let me know if you run into any problems.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  
350292364 https://github.com/simonw/datasette/issues/141#issuecomment-350292364 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDM1MDI5MjM2NA== simonw 9599 2017-12-08T15:33:18Z 2017-12-08T15:33:18Z OWNER

I can emulate this on OS X using a disk image (Disk Utility -> File -> New Image -> Blank Image...) - once mounted, I get the following:

>>> os.link('/tmp/hello', '/Volumes/Untitled/hello')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 18] Cross-device link: '/tmp/hello' -> '/Volumes/Untitled/hello'

I can simulate that in a mock like this:

>>> from unittest.mock import patch
>>> @patch('os.link')
... def test_link(mock_link):
...     mock_link.side_effect = OSError
...     mock_link()
...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  
346974336 https://github.com/simonw/datasette/issues/141#issuecomment-346974336 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDM0Njk3NDMzNg== janimo 50138 2017-11-26T00:00:35Z 2017-11-26T00:00:35Z NONE

FWIW I worked around this by setting TMPDIR to ~/tmp before running the command.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  
346157542 https://github.com/simonw/datasette/issues/141#issuecomment-346157542 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDM0NjE1NzU0Mg== simonw 9599 2017-11-21T20:53:47Z 2017-11-21T20:53:47Z OWNER

I think a copy is the right thing to do here - it will be cleaned up when the temp directory is removed. The hard link thing was always intended to save space, but if we can't do a hard link I don't see any harm in a temporary file copy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);