issue_comments

Table actions

3 rows where issue = 276091279 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • apsw as alternative sqlite3 binding (for full text search) · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
392606044 https://github.com/simonw/datasette/issues/144#issuecomment-392606044 https://api.github.com/repos/simonw/datasette/issues/144 MDEyOklzc3VlQ29tbWVudDM5MjYwNjA0NA== simonw 9599 2018-05-28T21:29:42Z 2018-05-28T21:29:42Z OWNER

The other major limitation of APSW is its treatment of unicode: https://rogerbinns.github.io/apsw/types.html - it tells you that it is your responsibility to ensure that TEXT columns in your SQLite database are correctly encoded.

Since Datasette is designed to work against ANY SQLite database that someone may have already created, I see that as a show-stopping limitation.

Thanks to https://github.com/coleifer/sqlite-vtfunc I now have a working mechanism for virtual tables (I've even built a demo plugin with them - https://github.com/simonw/datasette-sql-scraper ) which was the main thing that interested me about APSW.

I'm going to close this as WONTFIX - I think Python's built-in sqlite3 is good enough, and is now so firmly embedded in the project that making it pluggable would be more trouble than it's worth.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 apsw as alternative sqlite3 binding (for full text search) 276091279  
346427794 https://github.com/simonw/datasette/issues/144#issuecomment-346427794 https://api.github.com/repos/simonw/datasette/issues/144 MDEyOklzc3VlQ29tbWVudDM0NjQyNzc5NA== mhalle 649467 2017-11-22T17:55:45Z 2017-11-22T17:55:45Z NONE

Thanks. There is a way to use pip to grab apsw, which also let's you configure it (flags to build extensions, use an internal sqlite, etc). Don't know how that works as a dependency for another package, though.

On November 22, 2017 11:38:06 AM EST, Simon Willison notifications@github.com wrote:

I have a solution for FTS already, but I'm interested in apsw as a mechanism for allowing custom virtual tables to be written in Python (pysqlite only lets you write custom functions)

Not having PyPI support is pretty tough though. I'm planning a plugin/extension system which would be ideal for things like an optional apsw mode, but that's a lot harder if apsw isn't in PyPI.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/simonw/datasette/issues/144#issuecomment-346405660

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 apsw as alternative sqlite3 binding (for full text search) 276091279  
346405660 https://github.com/simonw/datasette/issues/144#issuecomment-346405660 https://api.github.com/repos/simonw/datasette/issues/144 MDEyOklzc3VlQ29tbWVudDM0NjQwNTY2MA== simonw 9599 2017-11-22T16:38:05Z 2017-11-22T16:38:05Z OWNER

I have a solution for FTS already, but I'm interested in apsw as a mechanism for allowing custom virtual tables to be written in Python (pysqlite only lets you write custom functions)

Not having PyPI support is pretty tough though. I'm planning a plugin/extension system which would be ideal for things like an optional apsw mode, but that's a lot harder if apsw isn't in PyPI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 apsw as alternative sqlite3 binding (for full text search) 276091279  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);