issue_comments

Table actions

4 rows where issue = 292011379 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • 500 from missing table name · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
494459264 https://github.com/simonw/datasette/issues/184#issuecomment-494459264 https://api.github.com/repos/simonw/datasette/issues/184 MDEyOklzc3VlQ29tbWVudDQ5NDQ1OTI2NA== carlmjohnson 222245 2019-05-21T16:17:29Z 2019-05-21T16:17:29Z NONE

Reopening this because it still raises 500 for incorrect table capitalization.

Example:

I think because the table name exists but is not in its canonical form, it triggers a dict lookup error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 from missing table name 292011379  
380608340 https://github.com/simonw/datasette/issues/184#issuecomment-380608340 https://api.github.com/repos/simonw/datasette/issues/184 MDEyOklzc3VlQ29tbWVudDM4MDYwODM0MA== simonw 9599 2018-04-11T21:55:41Z 2018-04-11T21:55:41Z OWNER

Yuck, nasty - OK I get it, this happens with ANY non-existent table name. Let's fix that - these should clearly return an HTTP 404.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 from missing table name 292011379  
379788103 https://github.com/simonw/datasette/issues/184#issuecomment-379788103 https://api.github.com/repos/simonw/datasette/issues/184 MDEyOklzc3VlQ29tbWVudDM3OTc4ODEwMw== carlmjohnson 222245 2018-04-09T15:15:11Z 2018-04-09T15:15:11Z NONE 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 from missing table name 292011379  
379636068 https://github.com/simonw/datasette/issues/184#issuecomment-379636068 https://api.github.com/repos/simonw/datasette/issues/184 MDEyOklzc3VlQ29tbWVudDM3OTYzNjA2OA== simonw 9599 2018-04-09T05:26:21Z 2018-04-09T05:26:21Z OWNER

Do you have steps to reproduce here - ideally a small example SQLite database that exhibits the error?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 from missing table name 292011379  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);