issue_comments

Table actions

3 rows where issue = 310882100 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Cleaner mechanism for handling custom errors · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
380619851 https://github.com/simonw/datasette/issues/193#issuecomment-380619851 https://api.github.com/repos/simonw/datasette/issues/193 MDEyOklzc3VlQ29tbWVudDM4MDYxOTg1MQ== simonw 9599 2018-04-11T22:48:19Z 2018-04-11T22:48:19Z OWNER

I can clean this up further with the mechanism I'm using for #184

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cleaner mechanism for handling custom errors 310882100  
379624163 https://github.com/simonw/datasette/issues/193#issuecomment-379624163 https://api.github.com/repos/simonw/datasette/issues/193 MDEyOklzc3VlQ29tbWVudDM3OTYyNDE2Mw== simonw 9599 2018-04-09T04:03:49Z 2018-04-09T04:03:49Z OWNER

This is harder than I thought, because the _shape= logic actually runs AFTER the main block of code which is set up to catch exceptions - this code here:

https://github.com/simonw/datasette/blob/0abd3abacb309a2bd5913a7a2df4e9256585b1bb/datasette/app.py#L200-L216

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cleaner mechanism for handling custom errors 310882100  
379142500 https://github.com/simonw/datasette/issues/193#issuecomment-379142500 https://api.github.com/repos/simonw/datasette/issues/193 MDEyOklzc3VlQ29tbWVudDM3OTE0MjUwMA== carlmjohnson 222245 2018-04-06T04:05:58Z 2018-04-06T04:05:58Z NONE

You could try pulling out a validate query strings method. If it fails validation build the error object from the message. If it passes, you only need to go down a happy path. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cleaner mechanism for handling custom errors 310882100  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);