issue_comments

Table actions

6 rows where issue = 314455877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Don't duplicate simple primary keys in the link column · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
382210976 https://github.com/simonw/datasette/pull/209#issuecomment-382210976 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MjIxMDk3Ng== simonw 9599 2018-04-18T01:12:26Z 2018-04-18T01:12:26Z OWNER

OK, aaf59db570ab7688af72c08bb5bc1edc145e3e07 should mean that the tests pass when I merge that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  
382205189 https://github.com/simonw/datasette/pull/209#issuecomment-382205189 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MjIwNTE4OQ== simonw 9599 2018-04-18T00:42:44Z 2018-04-18T00:43:02Z OWNER

I managed to get a better error message out of that test. The server is returning this (but only on Python 3.6, not on Python 3.5 - and only in Travis, not in my local environment):

{'error': 'interrupted', 'ok': False, 'status': 400, 'title': 'Invalid SQL'}

https://travis-ci.org/simonw/datasette/jobs/367929134

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  
381905593 https://github.com/simonw/datasette/pull/209#issuecomment-381905593 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MTkwNTU5Mw== russss 45057 2018-04-17T08:50:28Z 2018-04-17T08:50:28Z CONTRIBUTOR

I've added another commit which puts classes a class on each <td> by default with its column name, and I've also made the PK column bold.

Unfortunately the tests are still failing on 3.6, which is weird. I can't reproduce locally...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  
381738137 https://github.com/simonw/datasette/pull/209#issuecomment-381738137 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MTczODEzNw== russss 45057 2018-04-16T20:27:43Z 2018-04-16T20:27:43Z CONTRIBUTOR

Tests now fixed, honest. The failing test on Travis looks like an intermittent sqlite failure which should resolve itself on a retry...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  
381483301 https://github.com/simonw/datasette/pull/209#issuecomment-381483301 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MTQ4MzMwMQ== simonw 9599 2018-04-16T05:25:08Z 2018-04-16T05:25:08Z OWNER

I think this is a good improvement. If you fix the tests I'll merge it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  
381441392 https://github.com/simonw/datasette/pull/209#issuecomment-381441392 https://api.github.com/repos/simonw/datasette/issues/209 MDEyOklzc3VlQ29tbWVudDM4MTQ0MTM5Mg== russss 45057 2018-04-15T21:59:15Z 2018-04-15T21:59:15Z CONTRIBUTOR

I suspected this would cause some test failures, but I'll wait for opinions before attempting to fix them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't duplicate simple primary keys in the link column 314455877  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);