issue_comments

Table actions

4 rows where issue = 316323336 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • metadata.json support for plugin configuration options · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
491943956 https://github.com/simonw/datasette/issues/231#issuecomment-491943956 https://api.github.com/repos/simonw/datasette/issues/231 MDEyOklzc3VlQ29tbWVudDQ5MTk0Mzk1Ng== simonw 9599 2019-05-13T18:56:21Z 2019-05-13T18:56:21Z OWNER

I implemented this a while ago but forgot to close the issue: https://datasette.readthedocs.io/en/stable/plugins.html#plugin-configuration

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 metadata.json support for plugin configuration options 316323336  
412291395 https://github.com/simonw/datasette/issues/231#issuecomment-412291395 https://api.github.com/repos/simonw/datasette/issues/231 MDEyOklzc3VlQ29tbWVudDQxMjI5MTM5NQ== simonw 9599 2018-08-11T17:54:41Z 2018-08-11T17:54:41Z OWNER

I'm going to separate the issue of enabling and disabling plugins from the existence of the plugins key. The format will simply be:

{ "plugins": { "name-of-plugin": { ... any structures you like go here, defined by the plugin ... } } }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 metadata.json support for plugin configuration options 316323336  
392305776 https://github.com/simonw/datasette/issues/231#issuecomment-392305776 https://api.github.com/repos/simonw/datasette/issues/231 MDEyOklzc3VlQ29tbWVudDM5MjMwNTc3Ng== simonw 9599 2018-05-27T05:10:46Z 2018-05-27T05:10:46Z OWNER

These plugin config options should be exposed to JavaScript as datasette.config.plugins

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 metadata.json support for plugin configuration options 316323336  
383315348 https://github.com/simonw/datasette/issues/231#issuecomment-383315348 https://api.github.com/repos/simonw/datasette/issues/231 MDEyOklzc3VlQ29tbWVudDM4MzMxNTM0OA== simonw 9599 2018-04-21T17:37:50Z 2018-04-22T23:06:04Z OWNER

I could also have an "autodetect": false option for that plugin to turn off autodetecting entirely.

Would be useful if the plugin didn't append its JavaScript in pages that it wasn't used for - that might require making the extra_js_urls() hook optionally aware of the columns and table and metadata.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 metadata.json support for plugin configuration options 316323336  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);