issue_comments

Table actions

4 rows where issue = 322283067 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Escaping named parameters in canned queries · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
626340387 https://github.com/simonw/datasette/issues/254#issuecomment-626340387 https://api.github.com/repos/simonw/datasette/issues/254 MDEyOklzc3VlQ29tbWVudDYyNjM0MDM4Nw== philroche 247131 2020-05-10T14:54:13Z 2020-05-10T14:54:13Z NONE

This has now been resolved and is not present in current version of datasette.

Sample query @simonw mentioned now returns as expected.

https://aggreg8streams.tinyviking.ie/simplestreams?sql=select+*+from+cloudimage+where+%22content_id%22+%3D+%22com.ubuntu.cloud%3Areleased%3Adownload%22+order+by+id+limit+10

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Escaping named parameters in canned queries 322283067  
388360255 https://github.com/simonw/datasette/issues/254#issuecomment-388360255 https://api.github.com/repos/simonw/datasette/issues/254 MDEyOklzc3VlQ29tbWVudDM4ODM2MDI1NQ== simonw 9599 2018-05-11T13:16:09Z 2018-05-11T22:45:31Z OWNER

Do you have an example I can look at?

I think I have a possible route for fixing this, but it's pretty tricky (it involves adding a full SQL statement parser, but that's needed for some other potential improvements as well).

In the meantime, is this causing actual errors for you or is it more of an inconvenience (form fields being displayed that don't actually do anything)?

Another potential solution here could be to allow canned queries to optionally declare their parameters in metadata.json

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Escaping named parameters in canned queries 322283067  
388497467 https://github.com/simonw/datasette/issues/254#issuecomment-388497467 https://api.github.com/repos/simonw/datasette/issues/254 MDEyOklzc3VlQ29tbWVudDM4ODQ5NzQ2Nw== simonw 9599 2018-05-11T22:06:00Z 2018-05-11T22:06:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Escaping named parameters in canned queries 322283067  
388367027 https://github.com/simonw/datasette/issues/254#issuecomment-388367027 https://api.github.com/repos/simonw/datasette/issues/254 MDEyOklzc3VlQ29tbWVudDM4ODM2NzAyNw== philroche 247131 2018-05-11T13:41:46Z 2018-05-11T13:41:46Z NONE

An example deployment @ https://datasette-zkcvlwdrhl.now.sh/simplestreams-270f20c/cloudimage?content_id__exact=com.ubuntu.cloud%3Areleased%3Adownload

It is not causing errors, more of an inconvenience. I have worked around it using a like query instead. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Escaping named parameters in canned queries 322283067  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);