issue_comments

I pushed this to Docker Hub https://hub.docker.com/r/datasetteproject/datasette/ and added notes on how to use it to the documentation: http://datasette.readthedocs.io/en/latest/installation.html#using-docker

Thank you very much! This is most excellent.

No objections; It's good to go @simonw

On Wed, 23 May 2018, 14:51 Simon Willison, notifications@github.com wrote:

@r4vi https://github.com/r4vi any objections to me merging this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/pull/280#issuecomment-391354237, or mute the thread https://github.com/notifications/unsubscribe-auth/AAihfM_2DN5WR2mkO-VK6ozDmkUQ4IMjks5t1WlcgaJpZM4UI_2m .

@r4vi any objections to me merging this?

Running: bash docker run -p 8001:8001 -v `pwd`:/mnt datasette \ datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \ --load-extension=/usr/local/lib/mod_spatialite.so

is now returning FTS5 enabled in the versions output:

json { "datasette": { "version": "0.22" }, "python": { "full": "3.6.5 (default, May 5 2018, 03:07:21) \n[GCC 6.3.0 20170516]", "version": "3.6.5" }, "sqlite": { "extensions": { "json1": null, "spatialite": "4.4.0-RC0" }, "fts_versions": [ "FTS5", "FTS4", "FTS3" ], "version": "3.23.1" } } The old query didn't work because specifying (t TEXT) caused an error

I grabbed just your Dockerfile and built it like this:

docker build . -t datasette

Once it had built, I ran it like this:

docker run -p 8001:8001 -v `pwd`:/mnt datasette \
    datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db \
        --load-extension=/usr/local/lib/mod_spatialite.so

(The fixtures.db file is created by running python tests/fixtures.py fixtures.db)

Then I visited http://localhost:8001/-/versions and I got this:

{
    "datasette": {
        "version": "0+unknown"
    },
    "python": {
        "full": "3.6.3 (default, Dec 12 2017, 06:37:05) \n[GCC 6.3.0 20170516]",
        "version": "3.6.3"
    },
    "sqlite": {
        "extensions": {
            "json1": null,
            "spatialite": "4.4.0-RC0"
        },
        "fts_versions": [
            "FTS4",
            "FTS3"
        ],
        "version": "3.23.1"
    }
}

Fantastic! I'm getting SQLite 3.23.1 and SpatiaLite 4.4.0-RC0

I'm going to clean this up for consistency tomorrow morning so hold off merging until then please

On Tue, May 22, 2018 at 6:34 PM, Simon Willison notifications@github.com wrote:

Yeah let's try this without pysqlite3 and see if we still get the correct version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/simonw/datasette/pull/280#issuecomment-391076458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m .

Yeah let's try this without pysqlite3 and see if we still get the correct version.

This looks amazing! Can't wait to try this out this evening.

```python

import sqlite3 sqlite3.sqlite_version '3.23.1'

``` running the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all?