home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 377518499 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 5

issue 1

  • Get Datasette working with Zeit Now v2's 100MB image size limit · 5 ✖

author_association 1

  • OWNER 5
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
448437245 https://github.com/simonw/datasette/issues/374#issuecomment-448437245 https://api.github.com/repos/simonw/datasette/issues/374 MDEyOklzc3VlQ29tbWVudDQ0ODQzNzI0NQ== simonw 9599 2018-12-19T01:35:59Z 2018-12-19T01:35:59Z OWNER

Closing this as Zeit went on a different direction with Now v2, so the 100MB limit is no longer a concern.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Get Datasette working with Zeit Now v2's 100MB image size limit 377518499  
439763268 https://github.com/simonw/datasette/issues/374#issuecomment-439763268 https://api.github.com/repos/simonw/datasette/issues/374 MDEyOklzc3VlQ29tbWVudDQzOTc2MzI2OA== simonw 9599 2018-11-19T03:45:44Z 2018-11-19T03:45:44Z OWNER

Another example that might be useful: https://github.com/poc-flask/alpine/blob/8e9f48a2351e106347dab36d08cf21dee865993e/Dockerfile

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Get Datasette working with Zeit Now v2's 100MB image size limit 377518499  
439763196 https://github.com/simonw/datasette/issues/374#issuecomment-439763196 https://api.github.com/repos/simonw/datasette/issues/374 MDEyOklzc3VlQ29tbWVudDQzOTc2MzE5Ng== simonw 9599 2018-11-19T03:45:13Z 2018-11-19T03:45:13Z OWNER

This looks like it might be a recipe for spatialite Python on Alpine Linux: https://github.com/bentrm/geopython/blob/8e52062d9545f4b7c1f04a3516354a5a9155e31f/Dockerfile

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Get Datasette working with Zeit Now v2's 100MB image size limit 377518499  
439762759 https://github.com/simonw/datasette/issues/374#issuecomment-439762759 https://api.github.com/repos/simonw/datasette/issues/374 MDEyOklzc3VlQ29tbWVudDQzOTc2Mjc1OQ== simonw 9599 2018-11-19T03:41:36Z 2018-11-19T03:41:36Z OWNER

It turned out Zeit didn't end up shipping the new 100MB-limit Docker-based Zeit 2.0 after all - they ended up going in a completely different direction, towards lambdas instead (which don't really fit the Datasette model): https://zeit.co/blog/now-2

But... as far as I can tell they have introduced the 100MB image size for all free Zeit accounts ever against their 1.0 platform. So we still need to solve this, or free Zeit users won't be able to use datasette publish now even while 1.0 is still available.

I made some notes on this here: https://simonwillison.net/2018/Nov/19/smaller-python-docker-images/

I've got it working for the Datasette Publish webapp, but I still need to fix datasette publish now to create much smaller patterns.

I know how to do this for regular datasette, but I haven't yet figured out an Alpine Linux pattern for spatialite extras:

https://github.com/simonw/datasette/blob/5e3a432a0caa23837fa58134f69e2f82e4f632a6/datasette/utils.py#L287-L300

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Get Datasette working with Zeit Now v2's 100MB image size limit 377518499  
435976262 https://github.com/simonw/datasette/issues/374#issuecomment-435976262 https://api.github.com/repos/simonw/datasette/issues/374 MDEyOklzc3VlQ29tbWVudDQzNTk3NjI2Mg== simonw 9599 2018-11-05T18:11:10Z 2018-11-05T18:11:10Z OWNER

I think there is a useful way forward here though: the image size may be limited to 100MB, but once the instance launches it gets access to a filesystem with a lot more space than that (possibly as much as 15GB given my initial poking around).

So... one potential solution here is to teach Datasette to launch from a smaller image and then download a larger SQLite file from a known URL as part of its initial startup.

Combined with the ability to get Now to always run at least one copy of an instance this could allow Datasette to host much larger SQLite databases on that platform while playing nicely with the Zeit v2 platform.

See also https://github.com/zeit/now-cli/issues/1523

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Get Datasette working with Zeit Now v2's 100MB image size limit 377518499  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 19.381ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows