issue_comments

Great - thanks again.

Hi Simon - I'm just (trying, at least) to follow along in the above. I can't try it out now, but I will if no one else gets to it. Sorry I didn't write any tests in the original bit of code I pushed - I was just trying to see if it could work & whether you'd want to maybe head in that direction. Anyway, thank you, I will certainly use this. Comment back here if no one tried it out & I'll make time.

@simonw You're welcome - I was just trying it out back in December as I thought it should work. Now there's a pandemic to work on though.... so no time at all for more at the moment. BTW, I have datasette running on several protein and full (virus) genome databases I build, and it's great - thank you! Hi and best regards to you & Nat :-)

I just updated #652 to remove a merge conflict. I think it's an easy way to add this functionality. I don't have time to do more though, sorry!

@simonw What about allowing a base url. The <base>....</base> tag has been around forever. Then just use all relative URLs, which I guess is likely what you already do. See https://www.w3schools.com/TAGs/tag_base.asp

Hmmm, wait, maybe my mindless (copy/paste) use of proxy_redirect is causing me grief...

Agreed, this would be nice to have. I'm currently working around it in nginx with additional location blocks:

```

location /datasette/ {
    proxy_pass         http://127.0.0.1:8001/;
    proxy_redirect     off;
    include proxy_params;
}

location /dna-protein-genome/ {
    proxy_pass         http://127.0.0.1:8001/dna-protein-genome/;
    proxy_redirect     off;
    include proxy_params;
}

location /rna-protein-genome/ {
    proxy_pass         http://127.0.0.1:8001/rna-protein-genome/;
    proxy_redirect     off;
    include proxy_params;
}

```

The 2nd and 3rd above are my databases. This works, but I have a small problem with URLs like /rna-protein-genome?params.... that I could fix with some more nginx munging. I seem to do this sort of thing once every 5 years and then have to look it all up again.

Thanks!