issue_comments

Table actions

8 rows where issue = 434321685 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • "datasette publish cloudrun" command to publish to Google Cloud Run · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
489250828 https://github.com/simonw/datasette/pull/434#issuecomment-489250828 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTI1MDgyOA== simonw 9599 2019-05-03T21:50:44Z 2019-05-03T21:50:44Z OWNER

Since there's a useful error message I'm OK with revisiting this in a few weeks to see if they change the CLI tool.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
489163939 https://github.com/simonw/datasette/pull/434#issuecomment-489163939 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTE2MzkzOQ== rprimet 10352819 2019-05-03T16:49:45Z 2019-05-03T16:50:03Z CONTRIBUTOR

The second time I ran the command I got an error:

ERROR: (gcloud.beta.run.deploy) Deployment endpoint was not found. Perhaps the provided region was invalid. Set the run/region property to a valid region and retry. Ex: gcloud config set run/region us-central1

Yes, I was able to reproduce this; I used to get prompted for a run region interactively by the gcloud tool before, but maybe this is changing? (the documentation now assumes run/region is set).

Not sure which course of action is best: making datasette ensure that run/region is set beforehand or wait a bit until the gcloud CLI stabilizes?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
489154360 https://github.com/simonw/datasette/pull/434#issuecomment-489154360 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTE1NDM2MA== simonw 9599 2019-05-03T16:18:18Z 2019-05-03T16:18:18Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
489138554 https://github.com/simonw/datasette/pull/434#issuecomment-489138554 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTEzODU1NA== simonw 9599 2019-05-03T15:36:48Z 2019-05-03T15:36:48Z OWNER

Here's my first working deployment: https://datasette-j7hipcg4aq-uc.a.run.app/fixtures-c35b6a5/facetable?_facet_array=tags

I deployed it using this:

datasette publish cloudrun fixtures.db --branch=master

The second time I ran the command I got an error:

ERROR: (gcloud.beta.run.deploy) Deployment endpoint was not found. Perhaps the
provided region was invalid. Set the `run/region` property to a valid region and
retry. Ex: `gcloud config set run/region us-central1`

So I ran the command it suggested and then everything worked:

gcloud config set run/region us-central1
datasette publish cloudrun fixtures.db --branch=master

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
489105665 https://github.com/simonw/datasette/pull/434#issuecomment-489105665 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTEwNTY2NQ== eyeseast 25778 2019-05-03T14:01:30Z 2019-05-03T14:01:30Z CONTRIBUTOR

This is exactly what I needed. Thank you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
489104146 https://github.com/simonw/datasette/pull/434#issuecomment-489104146 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4OTEwNDE0Ng== simonw 9599 2019-05-03T13:56:45Z 2019-05-03T13:56:45Z OWNER

This is amazing - works an absolute treat. Thank you very much!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
484699119 https://github.com/simonw/datasette/pull/434#issuecomment-484699119 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4NDY5OTExOQ== simonw 9599 2019-04-18T21:40:45Z 2019-04-18T21:40:45Z OWNER

I asked @andrewgodwin about this and he confirmed that if we want to read an environment variable we can't use the CMD [...] syntax in the way that we were using it.

He did suggest that if we're doing CMD ["sh", "-c", "datasette serve --port $PORT ..."] we may as well do this instead:

CMD "datasette serve --port $PORT ..."

We should apply some command-line escaping here - if the user passes --version-note=hello$there to datasette publish we need that $ not to be accidentally evaluated as an environment variable.

It looks like shlex.quote is the right way to do that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  
484694648 https://github.com/simonw/datasette/pull/434#issuecomment-484694648 https://api.github.com/repos/simonw/datasette/issues/434 MDEyOklzc3VlQ29tbWVudDQ4NDY5NDY0OA== simonw 9599 2019-04-18T21:23:56Z 2019-04-18T21:23:56Z OWNER

Thanks for looking into this!

To clarify: currently, the Dockerfile that we generate looks something like this:

CMD ["datasette", "serve", "--host", "0.0.0.0", "fixtures.db", "--cors", "--port", "8001"]

Your code here changes that CMD line to look like this instead, in order to set the port based on an environment variable:

CMD ["sh", "-c", "datasette serve --port $PORT ..."]

I wonder if this is the only way to do this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "datasette publish cloudrun" command to publish to Google Cloud Run 434321685  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);