issue_comments

Table actions

6 rows where issue = 513008936 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
551361792 https://github.com/simonw/datasette/issues/608#issuecomment-551361792 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM2MTc5Mg== simonw 9599 2019-11-08T02:51:36Z 2019-11-08T02:51:36Z OWNER

A nice undocumented bonus feature of this change is that you can see a full list of your Cloud Run services by running datasette publish cloudrun fixtures.db and then hitting Ctrl+C rather than continuing with the deploy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  
551361489 https://github.com/simonw/datasette/issues/608#issuecomment-551361489 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM2MTQ4OQ== simonw 9599 2019-11-08T02:50:03Z 2019-11-08T02:50:03Z OWNER

Here's the new interface: ``` $ datasette publish cloudrun fixtures.db Please provide a service name for this deployment

Using an existing service name will over-write it

Your existing services:

csvconf - created 2019-05-09T18:52:17.829Z - https://csvconf-j7hipcg4aq-uc.a.run.app fixtures - created 2019-11-08T02:22:14.048160Z - https://fixtures-j7hipcg4aq-uc.a.run.app

Service name: ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  
551354256 https://github.com/simonw/datasette/issues/608#issuecomment-551354256 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM1NDI1Ng== simonw 9599 2019-11-08T02:17:50Z 2019-11-08T02:17:50Z OWNER

If the user specifies --service I will use that without further questions.

If they don't I'm going to ask them to enter a service manually (like happens at the moment) BUT I'm not going to give them a default and I'm going to show them the list of currently deployed services in the UI.

I can get that by shelling out to gcloud beta run services list --platform=managed --format json

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  
551353133 https://github.com/simonw/datasette/issues/608#issuecomment-551353133 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM1MzEzMw== simonw 9599 2019-11-08T02:13:10Z 2019-11-08T02:13:10Z OWNER

Right now you're not asked to select a service until AFTER the image has been compiled and pushed: ``` 7f41a4f30654: Pushed 60c95c8aac78: Pushed 5bad104547b2: Pushed latest: digest: sha256:7737f14d8490bbea49f29a750401fe2bf8a69f3da3bc2fd1ec5d1a031abf1b06 size: 2849 DONE

ID CREATE_TIME DURATION SOURCE IMAGES STATUS 55b495e1-6862-464b-a99c-ee6eb1d8ac31 2019-11-08T02:08:14+00:00 35S gs://datasette-222320_cloudbuild/source/1573178893.56-8a2500be28d540e1baac7c6726c5c975.tgz gcr.io/datasette-222320/datasette (+1 more) SUCCESS ...

Service name (datasette): `` This defaults todatasette` which means you'll over-ride your previous deployment if you don't fully understand what is going on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  
551352256 https://github.com/simonw/datasette/issues/608#issuecomment-551352256 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM1MjI1Ng== simonw 9599 2019-11-08T02:09:43Z 2019-11-08T02:09:43Z OWNER

I'm going to improve the UI to make it less likely people will accidentally over-write an existing service instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  
551351754 https://github.com/simonw/datasette/issues/608#issuecomment-551351754 https://api.github.com/repos/simonw/datasette/issues/608 MDEyOklzc3VlQ29tbWVudDU1MTM1MTc1NA== simonw 9599 2019-11-08T02:07:40Z 2019-11-08T02:07:40Z OWNER

I'm nervous about how this will affect existing automation scripts that use this command.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Improve UI of "datasette publish cloudrun" to reduce chances of accidentally over-writing a service 513008936  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);