issue_comments

Table actions

3 rows where issue = 516370822 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Static assets no longer loading for installed plugins · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
548968034 https://github.com/simonw/datasette/issues/611#issuecomment-548968034 https://api.github.com/repos/simonw/datasette/issues/611 MDEyOklzc3VlQ29tbWVudDU0ODk2ODAzNA== simonw 9599 2019-11-01T22:11:33Z 2019-11-01T22:11:33Z OWNER

Or I could support both with-hyphens and with_underscores variants of the plugin names? That would provide a painless upgrade path - maybe this is something I could clean up in the backwards compatibility breaking 1.0 version?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Static assets no longer loading for installed plugins 516370822  
548967774 https://github.com/simonw/datasette/issues/611#issuecomment-548967774 https://api.github.com/repos/simonw/datasette/issues/611 MDEyOklzc3VlQ29tbWVudDU0ODk2Nzc3NA== simonw 9599 2019-11-01T22:10:31Z 2019-11-01T22:10:31Z OWNER

The alternative would be to ship brand new fixed versions of all of these plugins and have those fixes require a minimum release of Datasette.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Static assets no longer loading for installed plugins 516370822  
548967432 https://github.com/simonw/datasette/issues/611#issuecomment-548967432 https://api.github.com/repos/simonw/datasette/issues/611 MDEyOklzc3VlQ29tbWVudDU0ODk2NzQzMg== simonw 9599 2019-11-01T22:08:57Z 2019-11-01T22:09:16Z OWNER

Argh this is actually a bug in the already-shipped plugins themselves:

python @hookimpl def extra_js_urls(): return [ { "url": "https://unpkg.com/leaflet@1.5.1/dist/leaflet.js", "sri": "sha512-GffPMF3RvMeYyc1LWMHtK8EbPv0iNZ8/oTtHPx9/cc2ILxQ+u905qIwdpULaqDkyBKgOaB57QTMg7ztg8Jm2Og==", }, "/-/static-plugins/datasette_leaflet_geojson/datasette-leaflet-geojson.js", ] https://github.com/simonw/datasette-leaflet-geojson/blob/f8b5b1bd797b8c1b9a1771c259037dca258cce40/datasette_leaflet_geojson/init.py#L14-L22

Maybe I should revert #606?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Static assets no longer loading for installed plugins 516370822  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);