issue_comments

Table actions

4 rows where issue = 520715188 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Datasette should work with Python 3.8 (and drop compatibility with Python 3.5) · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
552745890 https://github.com/simonw/datasette/issues/622#issuecomment-552745890 https://api.github.com/repos/simonw/datasette/issues/622 MDEyOklzc3VlQ29tbWVudDU1Mjc0NTg5MA== simonw 9599 2019-11-12T05:52:49Z 2019-11-12T05:52:49Z OWNER

Released in Datasette 0.31.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette should work with Python 3.8 (and drop compatibility with Python 3.5) 520715188  
552731544 https://github.com/simonw/datasette/issues/622#issuecomment-552731544 https://api.github.com/repos/simonw/datasette/issues/622 MDEyOklzc3VlQ29tbWVudDU1MjczMTU0NA== simonw 9599 2019-11-12T04:41:48Z 2019-11-12T04:41:48Z OWNER

Here's where Python 3.5 started failing: https://travis-ci.org/simonw/datasette/builds/610682852

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette should work with Python 3.8 (and drop compatibility with Python 3.5) 520715188  
552730304 https://github.com/simonw/datasette/issues/622#issuecomment-552730304 https://api.github.com/repos/simonw/datasette/issues/622 MDEyOklzc3VlQ29tbWVudDU1MjczMDMwNA== simonw 9599 2019-11-12T04:34:55Z 2019-11-12T04:34:55Z OWNER

Confirmed: upgrading to uvicorn~=0.10.4 fixed it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette should work with Python 3.8 (and drop compatibility with Python 3.5) 520715188  
552729978 https://github.com/simonw/datasette/issues/622#issuecomment-552729978 https://api.github.com/repos/simonw/datasette/issues/622 MDEyOklzc3VlQ29tbWVudDU1MjcyOTk3OA== simonw 9599 2019-11-12T04:33:00Z 2019-11-12T04:33:00Z OWNER

Here's the error I'm getting with Python 3.8 at the moment: ~/Dropbox/Development/datasette $ venv-py3.8.0/bin/datasette --memory -p 8055 Serve! files=() (immutables=()) on port 8055 Traceback (most recent call last): File "venv-py3.8.0/bin/datasette", line 11, in <module> load_entry_point('datasette', 'console_scripts', 'datasette')() File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py", line 764, in __call__ return self.main(*args, **kwargs) File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py", line 717, in main rv = self.invoke(ctx) File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py", line 1137, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py", line 956, in invoke return ctx.invoke(self.callback, **ctx.params) File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/click/core.py", line 555, in invoke return callback(*args, **kwargs) File "/Users/simonw/Dropbox/Development/datasette/datasette/cli.py", line 365, in serve uvicorn.run(ds.app(), host=host, port=port, log_level="info") File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/main.py", line 279, in run server.run() File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/main.py", line 305, in run self.config.setup_event_loop() File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/config.py", line 218, in setup_event_loop loop_setup() File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvicorn/loops/auto.py", line 3, in auto_loop_setup import uvloop File "/Users/simonw/Dropbox/Development/datasette/venv-py3.8.0/lib/python3.8/site-packages/uvloop/__init__.py", line 7, in <module> from .loop import Loop as __BaseLoop # NOQA File "uvloop/includes/stdlib.pxi", line 114, in init uvloop.loop AttributeError: module 'sys' has no attribute 'set_coroutine_wrapper' I'm pretty confident upgrading uvicorn (and uvloop with it) will fix this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette should work with Python 3.8 (and drop compatibility with Python 3.5) 520715188  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);