issue_comments

Table actions

4 rows where issue = 558600274 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Remove .detect_column_types() from table, make it a documented API · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
581071434 https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071434 https://api.github.com/repos/simonw/sqlite-utils/issues/81 MDEyOklzc3VlQ29tbWVudDU4MTA3MTQzNA== simonw 9599 2020-02-01T21:32:34Z 2020-02-01T21:32:34Z OWNER

While I'm at it I think I'll rename it to suggest_column_types - it's not really detecting them since the input is just a list of dictionaries.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove .detect_column_types() from table, make it a documented API 558600274  
581071235 https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071235 https://api.github.com/repos/simonw/sqlite-utils/issues/81 MDEyOklzc3VlQ29tbWVudDU4MTA3MTIzNQ== simonw 9599 2020-02-01T21:30:09Z 2020-02-01T21:30:09Z OWNER

Actually I'll put it in the utils.py module.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove .detect_column_types() from table, make it a documented API 558600274  
581071116 https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071116 https://api.github.com/repos/simonw/sqlite-utils/issues/81 MDEyOklzc3VlQ29tbWVudDU4MTA3MTExNg== simonw 9599 2020-02-01T21:28:35Z 2020-02-01T21:28:53Z OWNER

Should I keep table.detect_column_types() working so as not to break existing code?

If it was part of the documented API then I wouldn't break that without bumping to 3.x. Since it's undocumented I'm going to make it as a breaking change instead (and bump the geojson-to-sqlite dependency version).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove .detect_column_types() from table, make it a documented API 558600274  
581071010 https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071010 https://api.github.com/repos/simonw/sqlite-utils/issues/81 MDEyOklzc3VlQ29tbWVudDU4MTA3MTAxMA== simonw 9599 2020-02-01T21:27:00Z 2020-02-01T21:27:00Z OWNER

Here's the current method:

https://github.com/simonw/sqlite-utils/blob/f7289174e66ae4d91d57de94bbd9d09fabf7aff4/sqlite_utils/db.py#L823-L845

If I make it a utility function instead of a class method I could ensure it is directly importable like so:

python from sqlite_utils import detect_column_types

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove .detect_column_types() from table, make it a documented API 558600274  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);