issue_comments

Table actions

5 rows where issue = 565552217 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Rethink how sanity checks work · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
586623462 https://github.com/simonw/datasette/issues/674#issuecomment-586623462 https://api.github.com/repos/simonw/datasette/issues/674 MDEyOklzc3VlQ29tbWVudDU4NjYyMzQ2Mg== simonw 9599 2020-02-15T17:36:53Z 2020-03-26T17:19:23Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rethink how sanity checks work 565552217  
586625451 https://github.com/simonw/datasette/issues/674#issuecomment-586625451 https://api.github.com/repos/simonw/datasette/issues/674 MDEyOklzc3VlQ29tbWVudDU4NjYyNTQ1MQ== simonw 9599 2020-02-15T17:57:43Z 2020-02-15T17:57:43Z OWNER

I don't have a unit test for other databases that can't be opened, but I tested it manually against a copy of an Apple Photos photos.db file (found using find ~/Library | grep photos.db) and got this: ``` $ datasette /tmp/photos.db Serve! files=('/tmp/photos.db',) (immutables=()) on port 8001 Usage: datasette serve [OPTIONS] [FILES]...

Error: Connection to /tmp/photos.db failed check: no such module: RidList_VirtualReaderModule ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rethink how sanity checks work 565552217  
586622557 https://github.com/simonw/datasette/issues/674#issuecomment-586622557 https://api.github.com/repos/simonw/datasette/issues/674 MDEyOklzc3VlQ29tbWVudDU4NjYyMjU1Nw== simonw 9599 2020-02-15T17:26:43Z 2020-02-15T17:38:56Z OWNER

datasette.utils.check_connection(conn)

I'd like it to be able to return an indicator of what the problem is, so that the spatialite check above can behave in a special way. So maybe it raises a ConnectionProblem exception if there is a problem? SpatialiteConnectionProblem can be a subclass of that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rethink how sanity checks work 565552217  
586622677 https://github.com/simonw/datasette/issues/674#issuecomment-586622677 https://api.github.com/repos/simonw/datasette/issues/674 MDEyOklzc3VlQ29tbWVudDU4NjYyMjY3Nw== simonw 9599 2020-02-15T17:28:03Z 2020-02-15T17:28:03Z OWNER

I can unit test this with a minimal SpatiaLite database, created like this: https://github.com/simonw/datasette/issues/673#issuecomment-586449286

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rethink how sanity checks work 565552217  
586622194 https://github.com/simonw/datasette/issues/674#issuecomment-586622194 https://api.github.com/repos/simonw/datasette/issues/674 MDEyOklzc3VlQ29tbWVudDU4NjYyMjE5NA== simonw 9599 2020-02-15T17:22:57Z 2020-02-15T17:22:57Z OWNER

I did some research for this in #673 - I think the solution is to split this out into a separate utility function:

https://github.com/simonw/datasette/blob/3ffb8f3b98252531d11897fd431711e9b8045ace/datasette/app.py#L219-L237

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rethink how sanity checks work 565552217  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);