issue_comments

Table actions

4 rows where issue = 573755726 and "updated_at" is on date 2020-10-15 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Mechanism for plugins to add action menu items for various things · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
709497595 https://github.com/simonw/datasette/issues/690#issuecomment-709497595 https://api.github.com/repos/simonw/datasette/issues/690 MDEyOklzc3VlQ29tbWVudDcwOTQ5NzU5NQ== simonw 9599 2020-10-15T18:04:35Z 2020-10-15T18:12:15Z OWNER

For the table actions: attaching it to a cog icon next to the table name could make sense.

This is the column action icon at twice the size, color #666.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for plugins to add action menu items for various things 573755726  
709500715 https://github.com/simonw/datasette/issues/690#issuecomment-709500715 https://api.github.com/repos/simonw/datasette/issues/690 MDEyOklzc3VlQ29tbWVudDcwOTUwMDcxNQ== simonw 9599 2020-10-15T18:10:32Z 2020-10-15T18:10:32Z OWNER

Row action menus are a question mark for me. Adding them to the table page itself could get really noisy - though maybe they're a vertical ... menu at the end of the row? They could also go on the row.html template, though that page is rarely used at the moment.

I'm going to skip row actions for the moment and concentrate on the other four, which I know I have use-cases for.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for plugins to add action menu items for various things 573755726  
709499944 https://github.com/simonw/datasette/issues/690#issuecomment-709499944 https://api.github.com/repos/simonw/datasette/issues/690 MDEyOklzc3VlQ29tbWVudDcwOTQ5OTk0NA== simonw 9599 2020-10-15T18:09:06Z 2020-10-15T18:09:06Z OWNER

I'm going to dedicate this issue to thinking about action menus. #981 added column action menus, others to build could be:

  • Table action menus (for things like configure FTS, edit schema)
  • Database action menus (import CSV file into this table)
  • Instance action menus (manage users, import CSV into this instance)
  • Column action menus (already there, plugins could include extract this column)
  • Row action menus?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for plugins to add action menu items for various things 573755726  
709498425 https://github.com/simonw/datasette/issues/690#issuecomment-709498425 https://api.github.com/repos/simonw/datasette/issues/690 MDEyOklzc3VlQ29tbWVudDcwOTQ5ODQyNQ== simonw 9599 2020-10-15T18:06:08Z 2020-10-15T18:06:08Z OWNER

And for instance-level actions (linking to datasette-import-csv for example) an actions menu anchored against a burger-bar menu icon in the navigation bar.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for plugins to add action menu items for various things 573755726  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);