issue_comments

Table actions

7 rows where issue = 576711589 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Update SQLite bundled with Docker container · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
596266225 https://github.com/simonw/datasette/issues/695#issuecomment-596266225 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NjI2NjIyNQ== simonw 9599 2020-03-08T23:33:23Z 2020-03-08T23:33:23Z OWNER

Shipped in Datasette 0.38.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595617762 https://github.com/simonw/datasette/issues/695#issuecomment-595617762 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxNzc2Mg== simonw 9599 2020-03-06T06:14:53Z 2020-03-06T06:14:53Z OWNER

SpatiaLite testing works fine. I'm going to ship this even though there's a single failing test, since that's not a regression from the previous Docker release. I'm going to file a separate issue about that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595617072 https://github.com/simonw/datasette/issues/695#issuecomment-595617072 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxNzA3Mg== simonw 9599 2020-03-06T06:12:07Z 2020-03-06T06:12:07Z OWNER

Well that's odd. If I run the tests against SQLite 3.26.0 inside the container I get the same failure there as well:

docker run -it -v `pwd`:/mnt datasetteproject/datasette:0.37.1 /bin/bash root@710eed6278b2:/# cd /mnt root@710eed6278b2:/mnt# pip install -e .[test] && pytest

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595614469 https://github.com/simonw/datasette/issues/695#issuecomment-595614469 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxNDQ2OQ== simonw 9599 2020-03-06T06:01:16Z 2020-03-06T06:01:16Z OWNER

Here's how to run the unit test suite inside the freshly built Docker container (built with a new SQLite): docker run -it -v `pwd`:/mnt datasette-sqlite /bin/bash root@0e1928cfdf79:/# cd /mnt root@0e1928cfdf79:/mnt# pip install -e .[test] root@0e1928cfdf79:/mnt# pytest I ran that against SQLite 3.31.1 and got one failure!

It was for test_searchable[/fixtures/searchable.json?_search=te*+AND+do*&_searchmode=raw-expected_rows3] ``` def test_searchable(app_client, path, expected_rows): response = app_client.get(path)

  assert expected_rows == response.json["rows"]

E AssertionError: assert [[1, 'barry c...sel', 'puma']] == [] E Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther'] E Full diff: E + [] E - [[1, 'barry cat', 'terry dog', 'panther'], E - [2, 'terry dog', 'sara weasel', 'puma']] ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595611438 https://github.com/simonw/datasette/issues/695#issuecomment-595611438 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxMTQzOA== simonw 9599 2020-03-06T05:48:44Z 2020-03-06T05:48:44Z OWNER

Need to test with SpatiaLite here too. docker run -p 8001:8001 -v `pwd`:/mnt \ datasette-sqlite \ datasette -p 8001 -h 0.0.0.0 /mnt/spatial.db \ --load-extension=/usr/local/lib/mod_spatialite.so

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595610855 https://github.com/simonw/datasette/issues/695#issuecomment-595610855 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxMDg1NQ== simonw 9599 2020-03-06T05:46:11Z 2020-03-06T05:46:11Z OWNER

On my laptop I can build and test like so:

cd datasette
docker build -t datasette-sqlite .
docker run -p 8001:8001 -v `pwd`:/mnt \
    datasette-sqlite \
    datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  
595610265 https://github.com/simonw/datasette/issues/695#issuecomment-595610265 https://api.github.com/repos/simonw/datasette/issues/695 MDEyOklzc3VlQ29tbWVudDU5NTYxMDI2NQ== simonw 9599 2020-03-06T05:43:36Z 2020-03-06T05:43:36Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update SQLite bundled with Docker container 576711589  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);