home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 592829135 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 6

issue 1

  • Support YAML in metadata - metadata.yaml · 6 ✖

author_association 1

  • OWNER 6
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
608062899 https://github.com/simonw/datasette/issues/713#issuecomment-608062899 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODA2Mjg5OQ== simonw 9599 2020-04-02T19:36:17Z 2020-04-02T19:36:17Z OWNER

Documentation: https://datasette.readthedocs.io/en/latest/metadata.html#using-yaml-for-metadata

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  
608062703 https://github.com/simonw/datasette/issues/713#issuecomment-608062703 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODA2MjcwMw== simonw 9599 2020-04-02T19:35:53Z 2020-04-02T19:35:53Z OWNER

https://github.com/simonw/datasette/blob/6717c719dd36dc2adc0f9da38a8c8e08129e96b4/datasette/utils/init.py#L795-L803

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  
608023877 https://github.com/simonw/datasette/issues/713#issuecomment-608023877 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODAyMzg3Nw== simonw 9599 2020-04-02T18:18:29Z 2020-04-02T18:19:43Z OWNER

Don't forget to fix the code in publish that loads and modifies metadata, e.g.:

https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/utils/init.py#L361-L367

And:

https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/publish/heroku.py#L156-L168

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  
608022801 https://github.com/simonw/datasette/issues/713#issuecomment-608022801 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODAyMjgwMQ== simonw 9599 2020-04-02T18:16:23Z 2020-04-02T18:16:23Z OWNER

I'm going to try to parse as JSON first, then fall back to YAML, then error.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  
608021760 https://github.com/simonw/datasette/issues/713#issuecomment-608021760 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODAyMTc2MA== simonw 9599 2020-04-02T18:14:20Z 2020-04-02T18:14:58Z OWNER

I'm going to depend on ~=5.3 https://github.com/yaml/pyyaml/blob/master/CHANGES - though I could probably depend on a much wider set of versions (or maybe even no pinned minimum version at all).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  
608020485 https://github.com/simonw/datasette/issues/713#issuecomment-608020485 https://api.github.com/repos/simonw/datasette/issues/713 MDEyOklzc3VlQ29tbWVudDYwODAyMDQ4NQ== simonw 9599 2020-04-02T18:11:53Z 2020-04-02T18:11:53Z OWNER

I can add https://pypi.org/project/PyYAML/ as a dependency for this.

One open question: how best to tell the difference between a JSON and a YAML file? I'd rather not do it based on a file extension.

Since I'm going to read the whole file into memory anyway (rather than try to stream it) and I only load it once at startup, maybe I try to parse with one and, if there's a parsing error, try the other one before giving up?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Support YAML in metadata - metadata.yaml 592829135  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 101.68ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows