issue_comments

Table actions

9 rows where issue = 607223136 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Replace "datasette publish --extra-options" with "--setting" · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1125342229 https://github.com/simonw/datasette/issues/741#issuecomment-1125342229 https://api.github.com/repos/simonw/datasette/issues/741 IC_kwDOBm6k_c5DE1wV eyeseast 25778 2022-05-12T19:21:16Z 2022-05-12T19:21:16Z CONTRIBUTOR

Came here to check if this had been flagged already. Was helping a colleague get something on Cloud Run and had to dig to find --extra-options="--setting sql_time_limit_ms 2500".

If I get some time next week, maybe I'll try to tackle it. Would definitely make things easier to be able to do something like this:

sh datasette publish cloudrun something.db --setting sql_time_limit_ms 2500

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
806166575 https://github.com/simonw/datasette/issues/741#issuecomment-806166575 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDgwNjE2NjU3NQ== simonw 9599 2021-03-24T20:30:33Z 2021-03-24T20:30:33Z OWNER

datasette package is a mostly unmaintained feature at this point - it has a bit of test coverage but I've not made any improvements to it in a few years, and I don't use it for my own projects.

I'll make this change to package at the same time as I land it for publish though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
806010960 https://github.com/simonw/datasette/issues/741#issuecomment-806010960 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDgwNjAxMDk2MA== zaneselvans 596279 2021-03-24T17:19:42Z 2021-03-24T17:19:42Z NONE

Ah, okay so --extra-options applies to both datasette publish and datasette package? There wren't any examples of it being used with publish in the docs, so this tripped me up for a bit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
747208543 https://github.com/simonw/datasette/issues/741#issuecomment-747208543 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDc0NzIwODU0Mw== simonw 9599 2020-12-17T05:09:03Z 2020-12-17T05:09:03Z OWNER

I really like this in datasette-publish-vercel - I'm definitely going to bring this to the other publish implementations as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
744142692 https://github.com/simonw/datasette/issues/741#issuecomment-744142692 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDc0NDE0MjY5Mg== simonw 9599 2020-12-14T03:28:56Z 2020-12-14T03:28:56Z OWNER

I'm going to try this out on datasette-publish-vercel first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
713171742 https://github.com/simonw/datasette/issues/741#issuecomment-713171742 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDcxMzE3MTc0Mg== simonw 9599 2020-10-20T22:16:25Z 2020-10-20T22:16:25Z OWNER

See also #992 which will rename --config to --setting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
703350401 https://github.com/simonw/datasette/issues/741#issuecomment-703350401 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDcwMzM1MDQwMQ== simonw 9599 2020-10-05T01:26:12Z 2020-10-05T01:26:12Z OWNER

Relevant support question on Twitter: https://twitter.com/simonw/status/1312926103627988993

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
619708914 https://github.com/simonw/datasette/issues/741#issuecomment-619708914 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDYxOTcwODkxNA== simonw 9599 2020-04-27T04:30:02Z 2020-04-27T04:30:24Z OWNER

This can generate a config.json file that's included the published deployment, thanks to the work in #731 (pull request #739).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  
619708745 https://github.com/simonw/datasette/issues/741#issuecomment-619708745 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDYxOTcwODc0NQ== simonw 9599 2020-04-27T04:29:26Z 2020-04-27T04:29:26Z OWNER

I can show deprecation warnings for --extra-options and remove the option entirely in Datasette 1.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);