issue_comments

Table actions

5 rows where issue = 608058890, "updated_at" is on date 2020-04-29 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 5 ✖

issue 1

  • link_or_copy_directory() error - Invalid cross-device link · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
621027697 https://github.com/simonw/datasette/issues/744#issuecomment-621027697 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMTAyNzY5Nw== simonw 9599 2020-04-29T07:08:09Z 2020-04-29T07:08:09Z OWNER

What operating system are you using? I need to figure out a way to replicate this bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620971526 https://github.com/simonw/datasette/issues/744#issuecomment-620971526 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MTUyNg== simonw 9599 2020-04-29T03:32:14Z 2020-04-29T03:32:14Z OWNER

@aborruso I think I have a branch with a fix - could you try it out?

Install the new branch like this:

pip install https://github.com/simonw/datasette/archive/issue-744.zip Then try running datasette publish heroku again.

If this fixes your bug I'll merge that pull request!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620970475 https://github.com/simonw/datasette/issues/744#issuecomment-620970475 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MDQ3NQ== simonw 9599 2020-04-29T03:27:20Z 2020-04-29T03:27:20Z OWNER

This exception handling was introduced in #141

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620970159 https://github.com/simonw/datasette/issues/744#issuecomment-620970159 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MDE1OQ== simonw 9599 2020-04-29T03:25:45Z 2020-04-29T03:25:45Z OWNER

https://docs.python.org/3/library/shutil.html#shutil.copytree says that shutil.Error should be raised here, so I think this is a bug in the link_or_copy_directory function.

I don't have an environment that can replicate this bug. @aborruso I'm going to ship a fix in a branch that you can test against.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620969639 https://github.com/simonw/datasette/issues/744#issuecomment-620969639 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk2OTYzOQ== simonw 9599 2020-04-29T03:23:31Z 2020-04-29T03:23:31Z OWNER

Is it possible that your /tmp directory is on a different volume from the template folder? That could cause a problem with the symlinks.

Here's the code in question:

https://github.com/simonw/datasette/blob/89c4ddd4828623888e91a1d2cb396cba12d4e7b4/datasette/utils/init.py#L595-L609

It looks to me like we were expecting an OSError but in your environment you got a shutil.Error instead. So a fix could be to capture that error as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);