issue_comments

Table actions

3 rows where issue = 626171242 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • simonw · 3 ✖

issue 1

  • Error pages not correctly loading CSS · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
640957423 https://github.com/simonw/datasette/issues/777#issuecomment-640957423 https://api.github.com/repos/simonw/datasette/issues/777 MDEyOklzc3VlQ29tbWVudDY0MDk1NzQyMw== simonw 9599 2020-06-09T00:29:03Z 2020-06-09T00:29:03Z OWNER

Here's why:

https://github.com/simonw/datasette/blob/49d6d2f7b0f6cb02e25022e1c9403811f1fa0a7c/datasette/app.py#L1024-L1029

404 errors are rendered by looking for a template from ["404.html", "500.html"].

404.html doesn't actually ship with Datasette (plugins or custom template directories can provide it). So the 500.html template is used.

That template extends base.html, which expects there to be base_url and app_css_hash variables. But as you can see in the excerpt above, those variables are not being passed to the template context when the error page is rendered.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Error pages not correctly loading CSS 626171242  
640955788 https://github.com/simonw/datasette/issues/777#issuecomment-640955788 https://api.github.com/repos/simonw/datasette/issues/777 MDEyOklzc3VlQ29tbWVudDY0MDk1NTc4OA== simonw 9599 2020-06-09T00:23:26Z 2020-06-09T00:23:57Z OWNER

Clue: https://latest.datasette.io/404 displays correctly but https://latest.datasette.io/fixtures/404 does not.

That's because <link rel="stylesheet" href="-/static/app.css?"> does the correct thing if you are on the root of the site but not if you are in a sub-directory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Error pages not correctly loading CSS 626171242  
640925018 https://github.com/simonw/datasette/issues/777#issuecomment-640925018 https://api.github.com/repos/simonw/datasette/issues/777 MDEyOklzc3VlQ29tbWVudDY0MDkyNTAxOA== simonw 9599 2020-06-08T22:41:42Z 2020-06-08T22:41:42Z OWNER

This is particularly worth fixing now that 403 forbidden pages are much more likely due to #811.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Error pages not correctly loading CSS 626171242  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);