issue_comments

Table actions

3 rows where issue = 626663119 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • request.url and request.scheme should obey force_https_urls config setting · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
635494730 https://github.com/simonw/datasette/issues/781#issuecomment-635494730 https://api.github.com/repos/simonw/datasette/issues/781 MDEyOklzc3VlQ29tbWVudDYzNTQ5NDczMA== simonw 9599 2020-05-28T17:39:54Z 2020-05-28T17:39:54Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.url and request.scheme should obey force_https_urls config setting 626663119  
635471007 https://github.com/simonw/datasette/issues/781#issuecomment-635471007 https://api.github.com/repos/simonw/datasette/issues/781 MDEyOklzc3VlQ29tbWVudDYzNTQ3MTAwNw== simonw 9599 2020-05-28T16:58:47Z 2020-05-28T16:58:47Z OWNER

I'm inclined to do this at the earliest possible moment. I think that's probably in the DatasetteRouter class, which should see every scope first and be able to apply that setting to it. It already has some special case logic to deal with the base_url setting here:

https://github.com/simonw/datasette/blob/40885ef24e32d91502b6b8bbad1c7376f50f2830/datasette/app.py#L779-L789

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.url and request.scheme should obey force_https_urls config setting 626663119  
635468994 https://github.com/simonw/datasette/issues/781#issuecomment-635468994 https://api.github.com/repos/simonw/datasette/issues/781 MDEyOklzc3VlQ29tbWVudDYzNTQ2ODk5NA== simonw 9599 2020-05-28T16:55:35Z 2020-05-28T16:55:35Z OWNER

I think the right way to fix this is to modify the scope["scheme"] ASGI key before the Request object is constructed - otherwise that Request class will have to gain knowledge of Datasette's configuration mechanism.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 request.url and request.scheme should obey force_https_urls config setting 626663119  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);