issue_comments

18 rows where issue = 632843030 sorted by updated_at descending

View and edit SQL

Suggested facets: created_at (date), updated_at (date)

user

issue

  • Ability to ship alpha and beta releases · 18

author_association

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue
646320237 https://github.com/simonw/datasette/issues/807#issuecomment-646320237 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjMyMDIzNw== simonw 9599 2020-06-18T21:41:16Z 2020-06-18T21:41:16Z OWNER

https://pypi.org/project/datasette/0.45a0/ is the release on PyPI.

And in a fresh virtual environment:

$ pip install datasette==0.45a0
...
$ datasette --version
datasette, version 0.45a0

But running pip install datasette still gets 0.44.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646319315 https://github.com/simonw/datasette/issues/807#issuecomment-646319315 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjMxOTMxNQ== simonw 9599 2020-06-18T21:38:56Z 2020-06-18T21:38:56Z OWNER

This worked!

https://pypi.org/project/datasette/#history

https://github.com/simonw/datasette/releases/tag/0.45a0 is my manually created GitHub prerelease.

https://datasette.readthedocs.io/en/latest/changelog.html#a0-2020-06-18 has the release notes.

A shame Read The Docs doesn't seem to build the docs for these releases -it's not showing the tag in the releases pane here:

Also the new tag isn't an option in the Build menu on https://readthedocs.org/projects/datasette/builds/

Not a big problem though since the "latest" tag on Read The Docs will still carry the in-development documentation.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646303240 https://github.com/simonw/datasette/issues/807#issuecomment-646303240 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjMwMzI0MA== simonw 9599 2020-06-18T21:00:41Z 2020-06-18T21:00:41Z OWNER

New documentation about the alpha/beta releases: https://datasette.readthedocs.io/en/latest/contributing.html#contributing-alpha-beta

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646302909 https://github.com/simonw/datasette/issues/807#issuecomment-646302909 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjMwMjkwOQ== simonw 9599 2020-06-18T21:00:02Z 2020-06-18T21:00:02Z OWNER

Alpha release is running through Travis now: https://travis-ci.org/github/simonw/datasette/builds/699864168

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646293670 https://github.com/simonw/datasette/issues/807#issuecomment-646293670 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI5MzY3MA== simonw 9599 2020-06-18T20:38:50Z 2020-06-18T20:38:50Z OWNER

https://pypi.org/project/datasette-render-images/#history worked:

I'm now confident enough that I'll make these changes and ship an alpha of Datasette itself.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646293029 https://github.com/simonw/datasette/issues/807#issuecomment-646293029 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI5MzAyOQ== simonw 9599 2020-06-18T20:37:28Z 2020-06-18T20:37:46Z OWNER

Here's the Read The Docs documentation on versioned releases: https://docs.readthedocs.io/en/stable/versions.html

It looks like they do the right thing:

We in fact are parsing your tag names against the rules given by PEP 440. This spec allows “normal” version numbers like 1.4.2 as well as pre-releases. An alpha version or a release candidate are examples of pre-releases and they look like this: 2.0a1.

We only consider non pre-releases for the stable version of your documentation.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646292578 https://github.com/simonw/datasette/issues/807#issuecomment-646292578 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI5MjU3OA== simonw 9599 2020-06-18T20:36:22Z 2020-06-18T20:36:22Z OWNER

https://travis-ci.com/github/simonw/datasette-render-images/builds/172118541 demonstrates that the alpha/beta conditional is working as intended:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646291309 https://github.com/simonw/datasette/issues/807#issuecomment-646291309 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI5MTMwOQ== simonw 9599 2020-06-18T20:33:31Z 2020-06-18T20:33:31Z OWNER

One more experiment: I'm going to ship datasette-render-images 0.2 and see if that works correctly - including printing out the new debug section I put in the Travis config here: https://github.com/simonw/datasette-render-images/blob/6b5f22dab75ca364f671f5597556d2665a251bd8/.travis.yml#L35-L39 - which should demonstrate if my conditional for pushing to Docker Hub will work or not.

In the alpha releasing run on Travis that echo statement did NOT execute: https://travis-ci.com/github/simonw/datasette-render-images/builds/172116625

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646290171 https://github.com/simonw/datasette/issues/807#issuecomment-646290171 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI5MDE3MQ== simonw 9599 2020-06-18T20:30:48Z 2020-06-18T20:30:48Z OWNER

OK, I just shipped 0.2a0 of datasette-render-images - https://pypi.org/project/datasette-render-images/ has no indication of that:

But this page does: https://pypi.org/project/datasette-render-images/#history

And https://pypi.org/project/datasette-render-images/0.2a0/ exists.

In a fresh virtual environment pip install datasette-render-images gets 0.1.

pip install datasette-render-images==0.2a0 gets 0.2a0.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646280134 https://github.com/simonw/datasette/issues/807#issuecomment-646280134 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI4MDEzNA== simonw 9599 2020-06-18T20:08:15Z 2020-06-18T20:08:15Z OWNER

https://github.com/simonw/datasette-render-images uses Travis and is low-risk for trying this out.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646279428 https://github.com/simonw/datasette/issues/807#issuecomment-646279428 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3OTQyOA== simonw 9599 2020-06-18T20:06:43Z 2020-06-18T20:06:43Z OWNER

I'm going to try this on a separate repository so I don't accidentally publish a Datasette release I didn't mean to publish!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646279280 https://github.com/simonw/datasette/issues/807#issuecomment-646279280 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3OTI4MA== simonw 9599 2020-06-18T20:06:24Z 2020-06-18T20:06:24Z OWNER

So maybe this condition is right?

if: (tag IS present) AND NOT (tag =~ [ab])
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646278801 https://github.com/simonw/datasette/issues/807#issuecomment-646278801 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3ODgwMQ== simonw 9599 2020-06-18T20:05:18Z 2020-06-18T20:05:18Z OWNER

Travis conditions documentation: https://docs.travis-ci.com/user/conditions-v1

These look useful:

branch =~ /^(one|two)-three$/
(tag =~ ^v) AND (branch = master)
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646277680 https://github.com/simonw/datasette/issues/807#issuecomment-646277680 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3NzY4MA== simonw 9599 2020-06-18T20:02:42Z 2020-06-18T20:02:42Z OWNER

So I think if I push a tag of 0.45a0 everything might just work - Travis will build it, push the build to PyPI, PyPI won't treat it as a stable release.

Except... I don't want to push alphas as Docker images - so I need to fix this code:

https://github.com/simonw/datasette/blob/6151c25a5a8d566c109af296244b9267c536bd9a/.travis.yml#L34-L43

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646277155 https://github.com/simonw/datasette/issues/807#issuecomment-646277155 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3NzE1NQ== simonw 9599 2020-06-18T20:01:31Z 2020-06-18T20:01:31Z OWNER

I thought I might have to update a regex (my CircleCI configs won't match on a0, example) but it turns out Travis is currently configured to treat ALL tags as potential releases:

https://github.com/simonw/datasette/blob/6151c25a5a8d566c109af296244b9267c536bd9a/.travis.yml#L21-L35

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646276150 https://github.com/simonw/datasette/issues/807#issuecomment-646276150 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3NjE1MA== simonw 9599 2020-06-18T19:59:17Z 2020-06-18T19:59:17Z OWNER

Relevant PEP: https://www.python.org/dev/peps/pep-0440/

Django's implementation dates back 8 years: https://github.com/django/django/commit/40f0ecc56a23d35c2849f8e79276f6d8931412d1

From the PEP:

Implicit pre-release number

Pre releases allow omitting the numeral in which case it is implicitly assumed to be 0. The normal form for this is to include the 0 explicitly. This allows versions such as 1.2a which is normalized to 1.2a0.

I'm going to habitually include the 0.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
646273035 https://github.com/simonw/datasette/issues/807#issuecomment-646273035 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0NjI3MzAzNQ== simonw 9599 2020-06-18T19:52:28Z 2020-06-18T19:52:28Z OWNER

I'd like this soon, because I want to start experimenting with things like #852 and #842 without shipping those plugin hooks in a full stable release.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030
640135332 https://github.com/simonw/datasette/issues/807#issuecomment-640135332 https://api.github.com/repos/simonw/datasette/issues/807 MDEyOklzc3VlQ29tbWVudDY0MDEzNTMzMg== simonw 9599 2020-06-07T00:13:51Z 2020-06-07T00:13:51Z OWNER

These should not be shipped as the latest version on Docker Hub. They also should not become the "stable" release on ReadTheDocs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Ability to ship alpha and beta releases 632843030

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Query took 25.671ms · About: github-to-sqlite