issue_comments

Table actions

3 rows where issue = 635107393 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Documentation is inconsistent about "id" as required field on actor · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
641353186 https://github.com/simonw/datasette/issues/823#issuecomment-641353186 https://api.github.com/repos/simonw/datasette/issues/823 MDEyOklzc3VlQ29tbWVudDY0MTM1MzE4Ng== simonw 9599 2020-06-09T14:58:36Z 2020-06-09T14:58:36Z OWNER

Docs now say:

The actor dictionary can be any shape - the design of that data structure is left up to the plugins. A useful convention is to include an "id" string, as demonstrated by the "root" actor below.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documentation is inconsistent about "id" as required field on actor 635107393  
641059221 https://github.com/simonw/datasette/issues/823#issuecomment-641059221 https://api.github.com/repos/simonw/datasette/issues/823 MDEyOklzc3VlQ29tbWVudDY0MTA1OTIyMQ== simonw 9599 2020-06-09T06:23:51Z 2020-06-09T06:24:09Z OWNER

I don't like the "id" requirement.

I can think of plenty of situations where a unique ID might not be available:

  • auth against an external token - an email address or a phone number for example
  • auth using encrypted tokens - where decrypting the token tells you exactly what permissions that token should have, like in https://blog.thea.codes/building-a-stateless-api-proxy/
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documentation is inconsistent about "id" as required field on actor 635107393  
641025760 https://github.com/simonw/datasette/issues/823#issuecomment-641025760 https://api.github.com/repos/simonw/datasette/issues/823 MDEyOklzc3VlQ29tbWVudDY0MTAyNTc2MA== simonw 9599 2020-06-09T04:48:40Z 2020-06-09T04:48:40Z OWNER

I should assert that "id" exists and is a string in the code that calls the actor_from_request hook.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documentation is inconsistent about "id" as required field on actor 635107393  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);