issue_comments

Table actions

6 rows where issue = 635147716 and "updated_at" is on date 2020-06-09 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Way to enable a default=False permission for anonymous users · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
641406944 https://github.com/simonw/datasette/issues/825#issuecomment-641406944 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTQwNjk0NA== simonw 9599 2020-06-09T16:12:02Z 2020-06-09T17:19:19Z OWNER

Alternative design: leave actor alone. Instead specify that allow blocks can look like this:

json { "allow": { "unauthenticated": true } }

I like this: the above block is very self-documenting.

The "id": "*" mechanism means there is already precedent for allow keys with special meaning.

I'm going with this design.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  
641452563 https://github.com/simonw/datasette/issues/825#issuecomment-641452563 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTQ1MjU2Mw== simonw 9599 2020-06-09T17:08:00Z 2020-06-09T17:08:00Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  
641449725 https://github.com/simonw/datasette/issues/825#issuecomment-641449725 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTQ0OTcyNQ== simonw 9599 2020-06-09T17:02:31Z 2020-06-09T17:02:31Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  
641412424 https://github.com/simonw/datasette/issues/825#issuecomment-641412424 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTQxMjQyNA== simonw 9599 2020-06-09T16:22:07Z 2020-06-09T16:22:07Z OWNER

When I implement this I should also document default allow vs default deny as a concept, and specify that default next to every documented permission.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  
641320947 https://github.com/simonw/datasette/issues/825#issuecomment-641320947 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTMyMDk0Nw== simonw 9599 2020-06-09T14:06:46Z 2020-06-09T14:06:46Z OWNER

I'm torn between anonymous and anon - because the latter is less typing, and I envisage people writing a lot of code like this:

python if actor.get("anonymous"): # ...

I'm going with anonymous because it's that tiny bit clearer than anon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  
641062164 https://github.com/simonw/datasette/issues/825#issuecomment-641062164 https://api.github.com/repos/simonw/datasette/issues/825 MDEyOklzc3VlQ29tbWVudDY0MTA2MjE2NA== simonw 9599 2020-06-09T06:30:24Z 2020-06-09T14:05:33Z OWNER

Idea: the anonymous actor could be passed to actor_matches_allow() as:

json {"anonymous": true}

Then allow blocks like this could be used to allow them:

json { "plugins": { "datasette-upload-csvs": { "allow": { "anonymous": true } } } }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to enable a default=False permission for anonymous users 635147716  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);