issue_comments

Table actions

3 rows where issue = 646448486 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • initial windows ci setup · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
650340914 https://github.com/simonw/datasette/pull/868#issuecomment-650340914 https://api.github.com/repos/simonw/datasette/issues/868 MDEyOklzc3VlQ29tbWVudDY1MDM0MDkxNA== codecov[bot] 22429695 2020-06-26T18:53:02Z 2021-07-10T23:41:42Z NONE

Codecov Report

Merging #868 (b452fcb) into master (0005281) will increase coverage by 0.49%. The diff coverage is 96.19%.

:exclamation: Current head b452fcb differs from pull request most recent head c99caba. Consider uploading reports for the commit c99caba to get more accurate results

```diff @@ Coverage Diff @@

master #868 +/-

========================================== + Coverage 82.91% 83.40% +0.49%
========================================== Files 26 27 +1
Lines 3547 3634 +87
========================================== + Hits 2941 3031 +90
+ Misses 606 603 -3
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/plugins.py | 82.35% <ø> (ø) | | | datasette/default_magic_parameters.py | 91.17% <91.17%> (ø) | | | datasette/app.py | 95.99% <97.91%> (+1.32%) | :arrow_up: | | datasette/hookspecs.py | 100.00% <100.00%> (ø) | | | datasette/utils/__init__.py | 93.93% <100.00%> (+0.08%) | :arrow_up: | | datasette/utils/asgi.py | 91.32% <100.00%> (+0.41%) | :arrow_up: | | datasette/views/base.py | 93.39% <100.00%> (-0.01%) | :arrow_down: | | datasette/views/database.py | 96.37% <100.00%> (-1.96%) | :arrow_down: | | datasette/views/table.py | 95.67% <0.00%> (-0.03%) | :arrow_down: | | ... and 6 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 180c7a5...c99caba. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 initial windows ci setup 646448486  
663924220 https://github.com/simonw/datasette/pull/868#issuecomment-663924220 https://api.github.com/repos/simonw/datasette/issues/868 MDEyOklzc3VlQ29tbWVudDY2MzkyNDIyMA== joshmgrant 702729 2020-07-26T01:29:00Z 2020-07-26T01:29:00Z NONE

Ok, so it's been a while but I think I'm making progress. The good news: I have come up with a configuration change for running the tests on Windows on GitHub Actions. The bad news: there's a bunch of extraneous errors on the Windows case. I think this is due to Windows file IO and sqlite in a lot of cases, so I'm working through it. I will eventually clean up this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 initial windows ci setup 646448486  
650600606 https://github.com/simonw/datasette/pull/868#issuecomment-650600606 https://api.github.com/repos/simonw/datasette/issues/868 MDEyOklzc3VlQ29tbWVudDY1MDYwMDYwNg== simonw 9599 2020-06-27T18:44:28Z 2020-06-27T18:44:28Z OWNER

This is really exciting! Thanks so much for looking into this.

I'm interested in moving CI for this repo over to GitHub Actions, so I'd be fine with you getting this to work as an Action rather than through Travis. If you can get it working in Travis though I'll happily land that and figure out how to convert that to GitHub Actions later on.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 initial windows ci setup 646448486  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);