issue_comments

Table actions

8 rows where issue = 684925907 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 8 ✖

issue 1

  • Upgrade CodeMirror · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
683448569 https://github.com/simonw/datasette/issues/948#issuecomment-683448569 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ0ODU2OQ== simonw 9599 2020-08-30T17:39:09Z 2020-08-30T18:34:34Z OWNER

So the steps needed are:

  • Download and extract latest CodeMirror zip file
  • Rename lib/codemirror.js to codemirror-5.57.0.js
  • Rename lib/codemirror.css to codemirror-5.57.0.css
  • Rename mode/sql/sql.js to codemirror-5.57.0-sql.js
  • Edit both JS files to make the top comment a /* */ block
  • Minify JavaScript files like this:
  • npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js --comments '/LICENSE/'
  • npx uglify-js codemirror-5.57.0-sql.js -o codemirror-5.57.0-sql.min.js --comments '/LICENSE/'
  • Check that the LICENSE comment did indeed survive minification
  • Minify CSS file like this:
  • npx clean-css-cli codemirror-5.57.0.css -o codemirror-5.57.0.min.css
  • Edit the _codemirror.html template to reference the new files
  • git rm the old files, git add the new files
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
683452613 https://github.com/simonw/datasette/issues/948#issuecomment-683452613 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ1MjYxMw== simonw 9599 2020-08-30T18:16:28Z 2020-08-30T18:16:28Z OWNER

I added documentation on how to upgrade CodeMirror for the future here: https://docs.datasette.io/en/latest/contributing.html#upgrading-codemirror

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
683449804 https://github.com/simonw/datasette/issues/948#issuecomment-683449804 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ0OTgwNA== simonw 9599 2020-08-30T17:51:18Z 2020-08-30T17:51:18Z OWNER

Copy and paste on mobile safari seems to work now. #655 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
683448635 https://github.com/simonw/datasette/issues/948#issuecomment-683448635 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ0ODYzNQ== simonw 9599 2020-08-30T17:39:54Z 2020-08-30T17:39:54Z OWNER

I'll wait for this to deploy to https://latest.datasette.io/ and then test it in various desktop and mobile browsers.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
683445704 https://github.com/simonw/datasette/issues/948#issuecomment-683445704 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ0NTcwNA== simonw 9599 2020-08-30T17:11:58Z 2020-08-30T17:33:30Z OWNER

One catch: this stripped the license information from the top of the JS.

I fixed this by editing the license to be a single /* ... */ block comment instead of multiple // lines and running this:

npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js --comments '/LICENSE/'

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
683445114 https://github.com/simonw/datasette/issues/948#issuecomment-683445114 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY4MzQ0NTExNA== simonw 9599 2020-08-30T17:06:39Z 2020-08-30T17:06:39Z OWNER

Minifying using npx: npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js npx uglify-js codemirror-5.57.0-sql.js -o codemirror-5.57.0-sql.min.js npx clean-css-cli codemirror-5.57.0.css -o codemirror-5.57.0.min.css

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
679355426 https://github.com/simonw/datasette/issues/948#issuecomment-679355426 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY3OTM1NTQyNg== simonw 9599 2020-08-24T20:43:07Z 2020-08-24T20:43:07Z OWNER

It would also be interesting to try out the SQL hint mode, which can autocomplete against tables and columns. This demo shows how to configure that: https://codemirror.net/mode/sql/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  
679333717 https://github.com/simonw/datasette/issues/948#issuecomment-679333717 https://api.github.com/repos/simonw/datasette/issues/948 MDEyOklzc3VlQ29tbWVudDY3OTMzMzcxNw== simonw 9599 2020-08-24T19:55:59Z 2020-08-24T19:55:59Z OWNER

CodeMirror 6 is in pre-release at the moment and is a complete rewrite. I'll stick with the 5.x series for now. https://github.com/codemirror/codemirror.next/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade CodeMirror 684925907  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);