issue_comments

Table actions

3 rows where issue = 712984738 and "updated_at" is on date 2020-12-30 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Documented HTML hooks for JavaScript plugin authors · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
752714747 https://github.com/simonw/datasette/issues/987#issuecomment-752714747 https://api.github.com/repos/simonw/datasette/issues/987 MDEyOklzc3VlQ29tbWVudDc1MjcxNDc0Nw== simonw 9599 2020-12-30T18:23:08Z 2020-12-30T18:23:20Z OWNER

In terms of "places to put your plugin content", the simplest solution I can think of is something like this: ```html

``` Alternative designs:

  • A documented JavaScript function that returns the CSS selector where plugins should put their content
  • A documented JavaScript function that returns a DOM node where plugins should put their content. This would allow the JavaScript to create the element if it does not already exist (though it wouldn't be obvious WHERE that element should be created)
  • Documented JavaScript functions for things like "append this node/HTML to the place-where-plugins-go"

I think the original option - an empty <div> with a known id attribute - is the right one to go with here. It's the simplest, it's very easy for custom template authors to understand and it acknowledges that plugins may have all kinds of extra crazy stuff they want to do - like checking in that div to see if another plugin has written to it already, for example.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documented HTML hooks for JavaScript plugin authors 712984738  
752697279 https://github.com/simonw/datasette/issues/987#issuecomment-752697279 https://api.github.com/repos/simonw/datasette/issues/987 MDEyOklzc3VlQ29tbWVudDc1MjY5NzI3OQ== simonw 9599 2020-12-30T17:23:27Z 2020-12-30T17:23:32Z OWNER

Related problem: right now if you're writing custom template it's not at all obvious how to write them such that visualization plugins like datasette-cluster-map will continue to work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documented HTML hooks for JavaScript plugin authors 712984738  
752696499 https://github.com/simonw/datasette/issues/987#issuecomment-752696499 https://api.github.com/repos/simonw/datasette/issues/987 MDEyOklzc3VlQ29tbWVudDc1MjY5NjQ5OQ== simonw 9599 2020-12-30T17:21:08Z 2020-12-30T17:21:08Z OWNER

More generally, I need to document certain areas of the page that JavaScript plugins are invited to append their content to - such that plugin authors can use them and feel confident that future changes to the Datasette templates won't break their plugins.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Documented HTML hooks for JavaScript plugin authors 712984738  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);