issue_comments

Table actions

3 rows where issue = 718953669 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Add a "delete" icon next to filters (in addition to "remove filter") · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
706828375 https://github.com/simonw/datasette/issues/1016#issuecomment-706828375 https://api.github.com/repos/simonw/datasette/issues/1016 MDEyOklzc3VlQ29tbWVudDcwNjgyODM3NQ== simonw 9599 2020-10-12T03:01:58Z 2020-10-12T03:01:58Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add a "delete" icon next to filters (in addition to "remove filter") 718953669  
706821561 https://github.com/simonw/datasette/issues/1016#issuecomment-706821561 https://api.github.com/repos/simonw/datasette/issues/1016 MDEyOklzc3VlQ29tbWVudDcwNjgyMTU2MQ== simonw 9599 2020-10-12T02:33:52Z 2020-10-12T02:33:52Z OWNER

Should this do the equivalent of clicking Apply for you? I don't think so - that wouldn't fit with how the rest of that block of controls works.

But if it makes the row vanish it may not be clear to the user that they still need to click Apply.

Easiest thing would be for it to select the "remove filter" column and blank out the boxes. I will try that first.

The code can go in table.js.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add a "delete" icon next to filters (in addition to "remove filter") 718953669  
706788010 https://github.com/simonw/datasette/issues/1016#issuecomment-706788010 https://api.github.com/repos/simonw/datasette/issues/1016 MDEyOklzc3VlQ29tbWVudDcwNjc4ODAxMA== simonw 9599 2020-10-11T23:50:39Z 2020-10-11T23:50:39Z OWNER

For consistency can reuse the icon used on selected facets:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add a "delete" icon next to filters (in addition to "remove filter") 718953669  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);