issue_comments

Table actions

6 rows where issue = 724369025 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Fallback to databases in inspect-data.json when no -i options are passed · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
809010713 https://github.com/simonw/datasette/pull/1031#issuecomment-809010713 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDgwOTAxMDcxMw== simonw 9599 2021-03-29T01:46:45Z 2021-03-29T01:46:45Z OWNER

Sorry I didn't get to this PR sooner. I've joint-credited you in the release notes for this fix: https://docs.datasette.io/en/stable/changelog.html#v0-56

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  
808989067 https://github.com/simonw/datasette/pull/1031#issuecomment-808989067 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDgwODk4OTA2Nw== simonw 9599 2021-03-29T00:23:41Z 2021-03-29T00:23:41Z OWNER

This bug should have been fixed in #1229 - let me know if that's not the case!

Thanks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  
744003454 https://github.com/simonw/datasette/pull/1031#issuecomment-744003454 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDc0NDAwMzQ1NA== frankier 299380 2020-12-13T12:52:56Z 2020-12-13T12:52:56Z NONE

Please let me know if there's anything I can do to help get this merged.

This is causing problems for me because it means when I build my Docker image my databases aren't considered immutable, which I would like them to be so that a download link is produced.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  
714289680 https://github.com/simonw/datasette/pull/1031#issuecomment-714289680 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA== frankier 299380 2020-10-22T07:23:52Z 2020-10-22T07:23:52Z NONE

The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation.

The reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  
714206875 https://github.com/simonw/datasette/pull/1031#issuecomment-714206875 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDcxNDIwNjg3NQ== simonw 9599 2020-10-22T04:01:19Z 2020-10-22T04:01:19Z OWNER

I don't fully understand the bug you're fixing here. Could you provide a bit more explanation?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  
711792622 https://github.com/simonw/datasette/pull/1031#issuecomment-711792622 https://api.github.com/repos/simonw/datasette/issues/1031 MDEyOklzc3VlQ29tbWVudDcxMTc5MjYyMg== codecov[bot] 22429695 2020-10-19T07:57:17Z 2020-10-19T07:57:17Z NONE

Codecov Report

Merging #1031 into main will decrease coverage by 0.02%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1031 +/-

========================================== - Coverage 84.63% 84.60% -0.03%
========================================== Files 28 28
Lines 3892 3892
========================================== - Hits 3294 3293 -1
- Misses 598 599 +1
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/cli.py | 74.22% <ø> (ø) | | | datasette/views/index.py | 96.49% <0.00%> (-1.76%) | :arrow_down: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 568bd7b...7e7eaa4. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fallback to databases in inspect-data.json when no -i options are passed 724369025  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);