issue_comments

Table actions

4 rows where issue = 729017519 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Add template block prior to extra URL loaders · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
718528252 https://github.com/simonw/datasette/pull/1049#issuecomment-718528252 https://api.github.com/repos/simonw/datasette/issues/1049 MDEyOklzc3VlQ29tbWVudDcxODUyODI1Mg== psychemedia 82988 2020-10-29T09:20:34Z 2020-10-29T09:20:34Z CONTRIBUTOR

That workaround is probably fine. I was trying to work out whether there might be other situations where a pre-external package load might be useful but couldn't offhand bring any other examples to mind. The static plugins option also looks interesting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add template block prior to extra URL loaders 729017519  
718340847 https://github.com/simonw/datasette/pull/1049#issuecomment-718340847 https://api.github.com/repos/simonw/datasette/issues/1049 MDEyOklzc3VlQ29tbWVudDcxODM0MDg0Nw== simonw 9599 2020-10-29T03:45:47Z 2020-10-29T03:48:26Z OWNER

thebe is the first time I've seen a library that requires you to set up some global JavaScript configuration before loading the script itself.

I'm hesitant to add an extra template block just to cover that one case since it's such a rare pattern. But it's important that thebelab can be used with Datasette.

Would this pattern work for you instead?

```html+jinja {% block extra_head %}

<script type="text/x-thebe-config"> { requestKernel: true, binderOptions: { repo: "binder-examples/requirements", }, } </script> <script src="https://unpkg.com/thebelab@latest/lib/index.js"></script>

{% endblock %} ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add template block prior to extra URL loaders 729017519  
718341542 https://github.com/simonw/datasette/pull/1049#issuecomment-718341542 https://api.github.com/repos/simonw/datasette/issues/1049 MDEyOklzc3VlQ29tbWVudDcxODM0MTU0Mg== simonw 9599 2020-10-29T03:48:12Z 2020-10-29T03:48:12Z OWNER

You could use Datasette's new {{ urls.static_plugins(...) }} template option - see https://docs.datasette.io/en/latest/internals.html#internals-datasette-urls - to generate a link to code that was bundled with the plugin:

```html+jinja {% block extra_head %}

<script type="text/x-thebe-config"> { requestKernel: true, binderOptions: { repo: "binder-examples/requirements", }, } </script> <script src="{{ urls.static_plugins("datasette-thebelab-plugin", "thebelab-index.js")"></script>

{% endblock %} ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add template block prior to extra URL loaders 729017519  
716146238 https://github.com/simonw/datasette/pull/1049#issuecomment-716146238 https://api.github.com/repos/simonw/datasette/issues/1049 MDEyOklzc3VlQ29tbWVudDcxNjE0NjIzOA== codecov[bot] 22429695 2020-10-25T13:13:32Z 2020-10-25T13:13:32Z NONE

Codecov Report

Merging #1049 into main will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1049 +/-

======================================= Coverage 84.72% 84.72%
======================================= Files 28 28
Lines 3942 3942
======================================= Hits 3340 3340
Misses 602 602
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42f4851...50a743a. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add template block prior to extra URL loaders 729017519  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);