issue_comments

Table actions

6 rows where issue = 732905360 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 6 ✖

issue 1

  • Table actions menu on view pages, not on query pages · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
719966176 https://github.com/simonw/datasette/issues/1067#issuecomment-719966176 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTk2NjE3Ng== simonw 9599 2020-10-31T17:51:31Z 2020-10-31T17:51:31Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  
719961701 https://github.com/simonw/datasette/issues/1067#issuecomment-719961701 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTk2MTcwMQ== simonw 9599 2020-10-31T17:11:59Z 2020-10-31T17:11:59Z OWNER

It bothers me that these aren't visible in any public demos. Maybe latest.datasette.io should include the my_plugins.py and my_plugins2.py plugins?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  
719959419 https://github.com/simonw/datasette/issues/1067#issuecomment-719959419 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTk1OTQxOQ== simonw 9599 2020-10-31T16:53:42Z 2020-10-31T16:53:42Z OWNER

For the 0.51 release I'm going to add tests that show this works on view pages. I won't implement it for query pages.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  
719956184 https://github.com/simonw/datasette/issues/1067#issuecomment-719956184 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTk1NjE4NA== simonw 9599 2020-10-31T16:26:09Z 2020-10-31T16:26:09Z OWNER

Should the hook provide an indication that it's running on a different type of page? I think yes for queries. Not sure about views - they behave very much like tables, and the plugin can always introspect to see if something is a view if it needs to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  
719322666 https://github.com/simonw/datasette/issues/1067#issuecomment-719322666 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTMyMjY2Ng== simonw 9599 2020-10-30T07:04:02Z 2020-10-30T07:04:02Z OWNER

Maybe rename it to actions_menu and have it work for database, view, table and query pages using different arguments on each.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  
719320948 https://github.com/simonw/datasette/issues/1067#issuecomment-719320948 https://api.github.com/repos/simonw/datasette/issues/1067 MDEyOklzc3VlQ29tbWVudDcxOTMyMDk0OA== simonw 9599 2020-10-30T07:02:37Z 2020-10-30T07:02:37Z OWNER

Yes, this should be possible - no point restricting what plugin authors can do with the feature. Will need to add some extra arguments to the plugin hook for this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table actions menu on view pages, not on query pages 732905360  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);