issue_comments

Table actions

4 rows where issue = 756876238 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Fix footer not sticking to bottom in short pages · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
861497548 https://github.com/simonw/datasette/pull/1130#issuecomment-861497548 https://api.github.com/repos/simonw/datasette/issues/1130 MDEyOklzc3VlQ29tbWVudDg2MTQ5NzU0OA== abdusco 3243482 2021-06-15T13:27:48Z 2021-06-15T13:27:48Z CONTRIBUTOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fix footer not sticking to bottom in short pages 756876238  
738907852 https://github.com/simonw/datasette/pull/1130#issuecomment-738907852 https://api.github.com/repos/simonw/datasette/issues/1130 MDEyOklzc3VlQ29tbWVudDczODkwNzg1Mg== abdusco 3243482 2020-12-04T17:22:29Z 2020-12-04T17:31:25Z CONTRIBUTOR

EDIT: I misunderstood the problem. This seems like a fix better suited for Safari. But I don't have any Apple device to test it.

css body { min-height: 100vh; min-height: -webkit-fill-available; } html { height: -webkit-fill-available; } https://css-tricks.com/css-fix-for-100vh-in-mobile-webkit/

It's actually not that difficult to fix. Well, this is actually a workaround to keep viewport in place.

I usually put a transition (forgot to do it here) that keeps page from resizing.

css .container { min-height: 100vh; transition: height 10000s steps(0); }

steps() function prevents excessive layout calculations, and lets the page snap back into place (10000s ~= 3h later) in a single step. This fix also prevents page from jumping around when the keyboard pops up and down.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fix footer not sticking to bottom in short pages 756876238  
738897582 https://github.com/simonw/datasette/pull/1130#issuecomment-738897582 https://api.github.com/repos/simonw/datasette/issues/1130 MDEyOklzc3VlQ29tbWVudDczODg5NzU4Mg== simonw 9599 2020-12-04T17:03:30Z 2020-12-04T17:03:30Z OWNER

I deployed this to https://datasette-issue-1129.vercel.app/ (using datasette publish vercel fixtures.db --branch 8d4c69c6fb0ef741a19070f5172017ea3522e83c --about_url https://github.com/simonw/datasette/issues/1129 --about datasette/issues/1129 --project datasette-issue-1129) - weirdly, on Mobile Safari the footer appears just below the visible window:

I've seen other problems with fixed footers on Mobile Safari too: at Eventbrite this was a really nasty problem for us to figure out: https://www.eventbrite.com/engineering/mobile-safari-why/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fix footer not sticking to bottom in short pages 756876238  
738620153 https://github.com/simonw/datasette/pull/1130#issuecomment-738620153 https://api.github.com/repos/simonw/datasette/issues/1130 MDEyOklzc3VlQ29tbWVudDczODYyMDE1Mw== codecov[bot] 22429695 2020-12-04T07:34:48Z 2020-12-04T07:34:48Z NONE

Codecov Report

Merging #1130 (8d4c69c) into main (49d8fc0) will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1130 +/-

======================================= Coverage 91.42% 91.42%
======================================= Files 31 31
Lines 3873 3873
======================================= Hits 3541 3541
Misses 332 332
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49d8fc0...8d4c69c. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Fix footer not sticking to bottom in short pages 756876238  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);